Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert deprecation of 'EVENT_SUITE_ADD_*' events #4764

Merged
merged 2 commits into from
Oct 3, 2021

Conversation

beatfactor
Copy link
Contributor

Description of the Change

Other projects (such as Nigthwatch.js) may be relying on these events in order to be able to extend the test suite object during the parsing cycle.

Alternate Designs

None.

Why should this be in core?

Benefits

Possible Drawbacks

Applicable issues

These is a minimal risk change and it has been reviewed in #4760.

@juergba juergba added area: integrations related to working with 3rd party software (e.g., babel, typescript) semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Oct 3, 2021
@juergba juergba linked an issue Oct 3, 2021 that may be closed by this pull request
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 94.428% when pulling 5d65912 on beatfactor:undeprecate-suite-add-event into 0ea732c on mochajs:master.

@juergba juergba added the run-browser-test run browser tests on forked PR if code is safe label Oct 3, 2021
@github-actions github-actions bot removed the run-browser-test run browser tests on forked PR if code is safe label Oct 3, 2021
Copy link
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beatfactor thank you.

@juergba juergba merged commit 111467f into mochajs:master Oct 3, 2021
@juergba juergba changed the title Remove listing of EVENT_SUITE_ADD* events as deprecated (#4760) Revert deprecation of 'EVENT_SUITE_ADD_*' events Oct 3, 2021
@juergba juergba added this to the next milestone Oct 3, 2021
@juergba
Copy link
Contributor

juergba commented Oct 3, 2021

re decreasing coverage: as usual ... when removing code, calculated coverage is nonsense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: integrations related to working with 3rd party software (e.g., babel, typescript) semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Un-deprecate the "suite" event
3 participants