Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node v17 into ci matrix #4777

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Add Node v17 into ci matrix #4777

merged 3 commits into from
Oct 27, 2021

Conversation

outsideris
Copy link
Contributor

@outsideris outsideris commented Oct 25, 2021 •
edited
Loading

Node 17 is a new Current version. So, mocha will run tests on Node v17.

And Netlify runs on node 12, but 12 is a pretty old version.
I updated it to Node 16. v16 will be the new LTS version soon.

@outsideris
ci: add node 17 to build matrix
ab05d5d 
Signed-off-by: Outsider <outsideris@gmail.com>
@outsideris
Copy link
Contributor Author

outsideris commented Oct 25, 2021 •
edited
Loading

I will check Netlify build time differences between node v12 and v16.

@coveralls
Copy link

coveralls commented Oct 25, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 94.428% when pulling d331adb on outsideris:node-version into 28b4824 on mochajs:master.

@outsideris
Copy link
Contributor Author

There was some errors I didn't expect when netlify build docs with Node v16.
I will test it in a different PR.

@outsideris outsideris requested a review from a team October 25, 2021 18:06
@outsideris outsideris changed the title Node version Add Node v17 into ci matrix Oct 25, 2021
juergba
juergba suggested changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Node tests don't run on v17.

.github/workflows/mocha.yml Show resolved Hide resolved
@outsideris
ci: add node 17 to build matrix
c471081 
Signed-off-by: Outsider <outsideris@gmail.com>
@outsideris
ci: use node v16 as default version
d331adb 
Signed-off-by: Outsider <outsideris@gmail.com>
@outsideris
Copy link
Contributor Author

I add v17 to test matrix.

And set v16 our default version on CI because node v16 LTS have released.

@juergba juergba merged commit a99d40c into mochajs:master Oct 27, 2021
@juergba juergba added type: chore generally involving deps, tooling, configuration, etc. qa semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Oct 27, 2021
@juergba juergba added this to the next milestone Oct 27, 2021
KuznetsovRoman pushed a commit to gemini-testing/mocha that referenced this pull request Sep 6, 2022
@outsideris @KuznetsovRoman
chore(ci): add Node v17 to test matrix (mochajs#4777)
44874a7 
Signed-off-by: Outsider <outsideris@gmail.com>
This was referenced May 21, 2024
Open
Open
Open
@WontonSam WontonSam mentioned this pull request Jun 8, 2024
Open
@leonmonson leonmonson mentioned this pull request Jul 27, 2024
Open
@federicomoneta federicomoneta mentioned this pull request Sep 9, 2024
Open
@metatrust-v metatrust-v mentioned this pull request Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juergba juergba juergba approved these changes

Assignees
No one assigned
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
v9.1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@outsideris @coveralls @juergba