-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace deprecated String.prototype.substr() #4852
Merged
juergba
merged 1 commit into
mochajs:master
from
CommanderRoot:fix/rm-deprecated-substr
Mar 22, 2022
Merged
chore: replace deprecated String.prototype.substr() #4852
juergba
merged 1 commit into
mochajs:master
from
CommanderRoot:fix/rm-deprecated-substr
Mar 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
juergba
added
the
run-browser-test
run browser tests on forked PR if code is safe
label
Mar 22, 2022
github-actions
bot
removed
the
run-browser-test
run browser tests on forked PR if code is safe
label
Mar 22, 2022
juergba
approved these changes
Mar 22, 2022
juergba
added
area: browser
browser-specific
area: reporters
involving a specific reporter
type: cleanup
a refactor
labels
Mar 22, 2022
juergba
added
the
semver-patch
implementation requires increase of "patch" version number; "bug fixes"
label
Mar 22, 2022
This was referenced Jul 16, 2024
This was referenced Jul 31, 2024
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: browser
browser-specific
area: reporters
involving a specific reporter
semver-patch
implementation requires increase of "patch" version number; "bug fixes"
type: cleanup
a refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.
Alternate Designs
It would also be possible to use
substring()
instead ofslice()
Why should this be in core?
Best to not use deprecated functions
Benefits
No more deprecated functions
Possible Drawbacks
None
Applicable issues
None so far