Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Repo: Tests broken on main for xunit after conflicting merge #5121

Closed
5 tasks done
JoshuaKGoldberg opened this issue Mar 26, 2024 · 0 comments · Fixed by #5122
Closed
5 tasks done

🛠 Repo: Tests broken on main for xunit after conflicting merge #5121

JoshuaKGoldberg opened this issue Mar 26, 2024 · 0 comments · Fixed by #5122
Assignees
Labels
area: repository tooling concerning ease of contribution status: accepting prs Mocha can use your help with this one! type: bug a defect, confirmed by a maintainer

Comments

@JoshuaKGoldberg
Copy link
Member

Tooling Suggestion Checklist

Overview

#4985 was passing in CI, but when merged into main as efbb147, CI started failing. Joyous. Example from https://github.com/mochajs/mocha/actions/runs/8251199633/job/22567745125:

  1 failing

  1) reporters
       xunit
         prints test cases with --reporter-options output (issue: 1864):
     Uncaught UnexpectedError: 
expected '<testsuite name="Mocha Tests" tests="2" failures="0" errors="0" skipped="0" timestamp="Tue, 12 Mar 2024 15:10:50 GMT" time="0.002">\n<testcase classname="suite" name="test1" file="/home/runner/work/mocha/mocha/test/integration/fixtures/passing.fixture.js" time="0"/>\n<testcase classname="suite" name="test2" file="/home/runner/work/mocha/mocha/test/integration/fixtures/passing.fixture.js" time="0"/>\n</testsuite>\n'
to contain '<testcase classname="suite" name="test1" time="'

<testsuite name="Mocha Tests" tests="2" failures="0" errors="0" skipped="0" timestamp="Tue, 12 Mar 2024 15:10:50 GMT" time="0.002">
<testcase classname="suite" name="test1" file="/home/runner/work/mocha/mocha/test/integration/fixtures/passing.fixture.js" time="0"/>
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
<testcase classname="suite" name="test2" file="/home/runner/work/mocha/mocha/test/integration/fixtures/passing.fixture.js" time="0"/>
</testsuite>


      at /home/runner/work/mocha/mocha/test/integration/reporters.spec.js:59:11
      at Array.forEach (<anonymous>)
      at /home/runner/work/mocha/mocha/test/integration/reporters.spec.js:58:24
      at /home/runner/work/mocha/mocha/test/integration/helpers.js:69:7
      at ChildProcess.<anonymous> (test/integration/helpers.js:352:5)
      at ChildProcess.emit (node:events:518:28)
      at maybeClose (node:internal/child_process:1105:16)
      at ChildProcess._handle.onexit (node:internal/child_process:305:5)
      set UNEXPECTED_FULL_TRACE=true to see the full stack trace

Additional Info

@voxpelli will fix this in a moment.

@JoshuaKGoldberg JoshuaKGoldberg added type: bug a defect, confirmed by a maintainer status: accepting prs Mocha can use your help with this one! area: repository tooling concerning ease of contribution labels Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: repository tooling concerning ease of contribution status: accepting prs Mocha can use your help with this one! type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants