-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: test link in html reporter #5224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Just one style nit, but nothing functionally blocking. 🚀
Will leave open for a bit in case anybody from @mochajs/maintenance-crew wants to take a look.
Oh, and - please sign the CLA so we can accept this @danny0838. |
danny0838
force-pushed
the
main
branch
2 times, most recently
from
October 12, 2024 00:58
6ec2434
to
92af340
Compare
Bumps the github-actions group with 1 update: [joelwmale/webhook-action](https://github.com/joelwmale/webhook-action). Updates `joelwmale/webhook-action` from 2.3.2 to 2.4.1 - [Release notes](https://github.com/joelwmale/webhook-action/releases) - [Commits](joelwmale/webhook-action@2.3.2...2.4.1) --- updated-dependencies: - dependency-name: joelwmale/webhook-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com>
- `grep` may not work as expected if a previous `fgrep` or `invert` parameter exists.
JoshuaKGoldberg
changed the title
fix test link in html reporter
fix: test link in html reporter
Oct 19, 2024
JoshuaKGoldberg
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prs
Overview
Fix as mentioned in the related issue comment.