Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of special include orders and forward declarations #3322

Open
eggrobin opened this issue Feb 6, 2022 · 0 comments
Open

Get rid of special include orders and forward declarations #3322

eggrobin opened this issue Feb 6, 2022 · 0 comments

Comments

@eggrobin
Copy link
Member

eggrobin commented Feb 6, 2022

Oddities such as the ones listed below are deeply confusing already, and are obviously module-hostile. There are probably better ways to deal with that.

// Because of circular dependencies, this file doesn't include
// generators_body.hpp. This will be done by quantities.hpp.
// Include before quantities_body.hpp all the bodies that want to see the
// definition of class Quantity.
#include "quantities/generators_body.hpp"
#include "quantities/wide_body.hpp"

Cross-module forward declarations are impossible, so we should probably try to minimize forward declarations as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant