Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should mockito kotlin have transitive dependency to mockito inline? #475

Closed
emartynov opened this issue Jan 19, 2023 · 7 comments
Closed

Comments

@emartynov
Copy link

Classes by default are closed for extension in Kotlin.
For mocking final classes, we have to use mockito inline.
So should mockito kotlin have transitive dependency to the kotlin inline?

@emartynov emartynov changed the title Should mockito kotlin have transitive dependency to mockito inline Should mockito kotlin have transitive dependency to mockito inline? Jan 19, 2023
@emartynov
Copy link
Author

This would also make a hard reference to all possible changes in the core mockito.

@TimvdLippe
Copy link
Contributor

mockito-core now uses the inline mockmaker by default per Mockito 5: https://github.com/mockito/mockito/releases/tag/v5.0.0

@emartynov
Copy link
Author

@TimvdLippe will mockito kotlin get a new release soon?

@TimvdLippe
Copy link
Contributor

@emartynov if you want to send us a PR that bumps Mockito and makes the CI pass, sure I can publish a new release.

@emartynov
Copy link
Author

I'm afraid, except for the version bump, there should be addressed #473 . I will check if I can write a variant of the mock function that covers this situation.

@emartynov
Copy link
Author

Ah sorry, I meant #474

@elomonaco
Copy link

having this support Mockito 5 would be amazing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants