-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve readme for PC users #135
base: master
Are you sure you want to change the base?
Conversation
I was not sure about the $ signs. But I think it is better to ditch them because they are showing up in the readme on the github page of the repository. |
Also I have a full description on how to setup MOD on a fresh ubuntu lunar lobster: https://github.com/rominator1983/completeModInstallationManual I do get that this could be against the interests of your company but since this is open source I thought there could as well be a good description on how to get it working on the PC too. I don't know if you want to point to this repository somewhere in the documentation? |
the $ is intended as such instructions are not meant to be blindly copy&pasted, best to understand what it is doing before running random commands. the thing that really needs fixing is changing git:// url type to https://, rest is mostly fine. mod-plugin-builder uses in any case, for running mod-ui and host stuff it is best to use https://github.com/moddevices/mod-panel as that sets up virtualenv and other bits all automatically, if the intention is to run it on desktop. regarding your installation manual, had a quick look and it is everything but simple... also using mod-host together with pipewire is likely to not work very well, pipewire tends to bind things per client and mod-host creates 1 client per plugin. Carla was in a similar situation and only somewhat recently it began to work proper, IIRC needing some hardcoded hints in pipewire directly so its jack layer works more similar to original jack2 for Carla (mainly for having all clients with the same clock, sample rate and buffersize, which is not always a guarantee under pipewire) |
Thanks for your quick response. As to my manual. |
If you gave me a hint on where to put the creation of directories in mod-panel I might provide you a PR. I saw some similar TODOs in mod-ui.sh and mod-sdk.sh and I'm a bit confused. Creation should there obviously only happen if the directories are not already created. |
I added the creation and start of the file-manager in mod-audio/mod-panel@a2d7883 so it goes into the mod-panel repo. I am not keen on adding info for creating these local dirs on the mod-ui side to be honest, it relies on the "mod-workdir" concept created in mod-plugin-builder project, which is related to mod-ui due to MOD but something best left aside. |
OK for me. I adapted the PR to only mention the possible export and the default directory and the GIT-URI. I might look into the directory creation to finish this PR but not today. Python is not my primary language and the directories should obviously be created automatically based on a list of file types so new files type directories get created automatically. I do understand that other things might be more important right now too. |
Describing user data in readme for PC users.
Fixes mod-audio/mod-host#59