Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update concrete values parser to use serde structs #1477

Closed
sanjit-bhat opened this issue Aug 9, 2022 · 0 comments · Fixed by #1601
Closed

Update concrete values parser to use serde structs #1477

sanjit-bhat opened this issue Aug 9, 2022 · 0 comments · Fixed by #1601
Assignees

Comments

@sanjit-bhat
Copy link
Contributor

sanjit-bhat commented Aug 9, 2022

The current deterministic values parser in kani-driver/src/exe_trace.rs works on arbitrary serde::Value types. This means that if we expect certain Value blobs to be arrays, we have to test for that and handle errors. With this change, we would complete the serde struct for traces in kani-driver/src/cbmc_output_parser.rs and use those objects directly. We would still have to walk down this structure to extract deterministic values, but we wouldn't need as much error handling since the blob would be automatically serialized into the right type.

@sanjit-bhat sanjit-bhat self-assigned this Aug 11, 2022
@sanjit-bhat sanjit-bhat changed the title Update det vals parser once new overall CBMC output parser is merged in Det playback: Update det vals parser to use serde structs Aug 11, 2022
@sanjit-bhat sanjit-bhat changed the title Det playback: Update det vals parser to use serde structs Update concrete values parser to use serde structs Aug 19, 2022
@adpaco-aws adpaco-aws moved this to Done in Kani v0.9 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants