Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Clap Derive API instead of Builder API in kani-compiler #1647

Closed
celinval opened this issue Sep 7, 2022 · 4 comments · Fixed by #2689
Closed

Use Clap Derive API instead of Builder API in kani-compiler #1647

celinval opened this issue Sep 7, 2022 · 4 comments · Fixed by #2689
Labels
[I] Refactoring / Clean Up Refactoring or cleaning up of existing code

Comments

@celinval
Copy link
Contributor

celinval commented Sep 7, 2022

kani-compiler parser could use a bit of cleaning. We should use Clap Derive API to keep it cleaner and similar to kani-driver logic.
@celinval celinval added Pri: low [I] Refactoring / Clean Up Refactoring or cleaning up of existing code labels Sep 7, 2022
@tedinski
Copy link
Contributor

tedinski commented Sep 7, 2022

FYI, I had a branch that did this. Clap 3 sad semantic breaking changes that meant it didn't eagerly parse short options anymore, breaking kani-compiler.

@tedinski
Copy link
Contributor

tedinski commented Sep 7, 2022

Oh, wow it's seen progress (maybe? haven't evaluated yet) just yesterday!

clap-rs/clap#3880

@celinval
Copy link
Contributor Author

celinval commented Sep 8, 2022

Yeah, it would be nice to move both parsers to a newer version of clap. The APIs are much nicer now.

@celinval
Copy link
Contributor Author

Maybe we should get rid of the queries all together. We can reintroduce them once we are ready to adopt Salsa.

@celinval celinval mentioned this issue Aug 17, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[I] Refactoring / Clean Up Refactoring or cleaning up of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the clap derive API for the command line arguments of kani-compiler JustusAdam/kani
2 participants
@tedinski @celinval