remove uneeded test and rename methods

Author: yannj-fr

tests/server/auth/test_protected_resource.py

@@ -12,7 +12,7 @@
 
 
 @pytest.fixture
-def protected_resource_app():
+def test_app():
     """Fixture to create protected resource routes for testing."""
 
     # Create the protected resource routes
@@ -29,21 +29,18 @@ def protected_resource_app():
 
 
 @pytest.fixture
-async def test_client(protected_resource_app: Starlette):
+async def test_client(test_app: Starlette):
     """Fixture to create an HTTP client for the protected resource app."""
-    async with httpx.AsyncClient(
-        transport=httpx.ASGITransport(app=protected_resource_app), base_url="https://mcptest.com"
-    ) as client:
+    async with httpx.AsyncClient(transport=httpx.ASGITransport(app=test_app), base_url="https://mcptest.com") as client:
         yield client
 
 
 @pytest.mark.anyio
-async def test_metadata_endpoint(self, test_client: httpx.AsyncClient):
+async def test_metadata_endpoint(test_client: httpx.AsyncClient):
     """Test the OAuth 2.0 Protected Resource metadata endpoint."""
 
-    response = await protected_resource_test_client.get("/.well-known/oauth-protected-resource")
-    metadata = response.json()
-    assert metadata == snapshot(
+    response = await test_client.get("/.well-known/oauth-protected-resource")
+    assert response.json() == snapshot(
         {
             "resource": "https://example.com/resource",
             "authorization_servers": ["https://auth.example.com/authorization"],

tests/shared/test_auth.py

@@ -1,8 +1,6 @@
 """Tests for OAuth 2.0 shared code."""
 
-import pytest
-
-from mcp.shared.auth import OAuthMetadata, ProtectedResourceMetadata
+from mcp.shared.auth import OAuthMetadata
 
 
 class TestOAuthMetadata:
@@ -39,84 +37,3 @@ def test_oidc(self):
                 "userinfo_endpoint": "https://example.com/oauth2/userInfo",
             }
         )
-
-
-class TestProtectedResourceMetadataInvalid:
-    """Tests for ProtectedResourceMetadata parsing."""
-
-    def test_invalid_metadata(self):
-        """Should throw when parsing invalid metadata."""
-        with pytest.raises(ValueError):
-            ProtectedResourceMetadata.model_validate(
-                {
-                    "resource": "Not a valid URL",
-                    "authorization_servers": ["https://example.com/oauth2/authorize"],
-                    "scopes_supported": ["read", "write"],
-                    "bearer_methods_supported": ["header"],
-                }
-            )
-
-    def test_valid_metadata(self):
-        """Should not throw when parsing protected resource metadata."""
-
-        ProtectedResourceMetadata.model_validate(
-            {
-                "resource": "https://example.com/resource",
-                "authorization_servers": ["https://example.com/oauth2/authorize"],
-                "scopes_supported": ["read", "write"],
-                "bearer_methods_supported": ["header"],
-            }
-        )
-
-    def test_valid_with_resource_metadata(self):
-        """Should not throw when parsing metadata with resource_name and resource_documentation."""
-
-        ProtectedResourceMetadata.model_validate(
-            {
-                "resource": "https://example.com/resource",
-                "authorization_servers": ["https://example.com/oauth2/authorize"],
-                "scopes_supported": ["read", "write"],
-                "bearer_methods_supported": ["header"],
-                "resource_name": "Example Resource",
-                "resource_documentation": "https://example.com/resource/documentation",
-            }
-        )
-
-    def test_valid_with_invalid_resource_documentation(self):
-        """Should throw when parsing metadata with resource_name and invalid resource_documentation."""
-        with pytest.raises(ValueError):
-            ProtectedResourceMetadata.model_validate(
-                {
-                    "resource": "https://example.com/resource",
-                    "authorization_servers": ["https://example.com/oauth2/authorize"],
-                    "scopes_supported": ["read", "write"],
-                    "bearer_methods_supported": ["header"],
-                    "resource_name": "Example Resource",
-                    "resource_documentation": "Not a valid URL",
-                }
-            )
-
-    def test_valid_full_protected_resource_metadata(self):
-        """Should not throw when parsing full metadata."""
-
-        ProtectedResourceMetadata.model_validate(
-            {
-                "resource": "https://example.com/resource",
-                "authorization_servers": ["https://example.com/oauth2/authorize"],
-                "jwks_uri": "https://example.com/.well-known/jwks.json",
-                "scopes_supported": ["read", "write"],
-                "bearer_methods_supported": ["header"],
-                "resource_signing_alg_values_supported": ["RS256"],
-                "resource_name": "Example Resource",
-                "resource_documentation": "https://example.com/resource/documentation",
-                "resource_policy_uri": "https://example.com/resource/policy",
-                "resource_tos_uri": "https://example.com/resource/tos",
-                "tls_client_certificate_bound_access_tokens": True,
-                # authorization_details_types_supported is a complex type
-                # so we use an empty list for simplicity
-                # see RFC9396
-                "authorization_details_types_supported": [],
-                "dpop_signing_alg_values_supported": ["RS256", "ES256"],
-                "dpop_signing_access_tokens": True,
-            }
-        )