Skip to content

Commit f176d67

Browse files
author
skyvanguard
committed
fix: remove unnecessary coverage pragmas now covered by tests
The new test exercises server code paths that were previously uncovered, making these pragmas invalid per strict-no-cover. Github-Issue:#1648
1 parent b8fe469 commit f176d67

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

src/mcp/server/lowlevel/server.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -748,9 +748,7 @@ async def _handle_request(
748748
request_data = None
749749
close_sse_stream_cb = None
750750
close_standalone_sse_stream_cb = None
751-
if message.message_metadata is not None and isinstance(
752-
message.message_metadata, ServerMessageMetadata
753-
): # pragma: no cover
751+
if message.message_metadata is not None and isinstance(message.message_metadata, ServerMessageMetadata):
754752
request_data = message.message_metadata.request_context
755753
close_sse_stream_cb = message.message_metadata.close_sse_stream
756754
close_standalone_sse_stream_cb = message.message_metadata.close_standalone_sse_stream

src/mcp/server/streamable_http.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -806,14 +806,14 @@ async def _handle_unsupported_request(self, request: Request, send: Send) -> Non
806806
)
807807
await response(request.scope, request.receive, send)
808808

809-
async def _validate_request_headers(self, request: Request, send: Send) -> bool: # pragma: no cover
809+
async def _validate_request_headers(self, request: Request, send: Send) -> bool:
810810
if not await self._validate_session(request, send):
811811
return False
812812
if not await self._validate_protocol_version(request, send):
813813
return False
814814
return True
815815

816-
async def _validate_session(self, request: Request, send: Send) -> bool: # pragma: no cover
816+
async def _validate_session(self, request: Request, send: Send) -> bool:
817817
"""Validate the session ID in the request."""
818818
if not self.mcp_session_id:
819819
# If we're not using session IDs, return True
@@ -842,7 +842,7 @@ async def _validate_session(self, request: Request, send: Send) -> bool: # prag
842842

843843
return True
844844

845-
async def _validate_protocol_version(self, request: Request, send: Send) -> bool: # pragma: no cover
845+
async def _validate_protocol_version(self, request: Request, send: Send) -> bool:
846846
"""Validate the protocol version header in the request."""
847847
# Get the protocol version from the request headers
848848
protocol_version = request.headers.get(MCP_PROTOCOL_VERSION_HEADER)

src/mcp/server/streamable_http_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ async def run_stateless_server(*, task_status: TaskStatus[None] = anyio.TASK_STA
182182
self.app.create_initialization_options(),
183183
stateless=True,
184184
)
185-
except Exception: # pragma: no cover
185+
except Exception:
186186
logger.exception("Stateless session crashed")
187187

188188
# Assert task group is not None for type checking

0 commit comments

Comments
 (0)