Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Regen Rates & Transformation Spell #365

Open
kamronbatman opened this issue Dec 27, 2020 · 1 comment
Open

Update Regen Rates & Transformation Spell #365

kamronbatman opened this issue Dec 27, 2020 · 1 comment

Comments

@kamronbatman
Copy link
Contributor

kamronbatman commented Dec 27, 2020

Looks like the only reason a transformation spell uses a timer is because of LichForm.
This can be rolled into regen rates directly, where a negative value (as appropriate), decrements health.

This would also eliminate the need for a timer altogether with TransformationSpells.

Looks like these conditions are checked on the timer, so they would need to be moved somewhere else too:

protected override void OnTick()
{
if (m_Mobile.Deleted || !m_Mobile.Alive || m_Mobile.Body != m_Spell.Body || m_Mobile.Hue != m_Spell.Hue)
{
TransformationSpellHelper.RemoveContext(m_Mobile, true);
Stop();
}
else
{
m_Spell.OnTick(m_Mobile);
}

@kamronbatman kamronbatman added good first issue Good for newcomers and removed good first issue Good for newcomers labels Dec 27, 2020
@kamronbatman
Copy link
Contributor Author

kamronbatman commented Dec 27, 2020

This might need more investigation on OSI, since it appears that on RunUO, you lose and simultaneously gain health separately. Should find out if this happens on OSI, or if the negative points and positive points are rolled in, and if the final amount is negative, you lose that many points (instead of gain) over 10 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant