Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSE parsers should support \r\n and \r line delimiters as specified by the spec #73

Closed
joshmossas opened this issue Jul 23, 2024 · 3 comments
Closed

SSE parsers should support \r\n and \r line delimiters as specified by the spec #73

joshmossas opened this issue Jul 23, 2024 · 3 comments
Labels
bug Something isn't working codegen Issues related to generator plugins lang:dart lang:kotlin lang:rust lang:ts

Comments

@joshmossas
Copy link
Member

joshmossas commented Jul 23, 2024 •
edited
Loading

The majority of the current SSE parsers only support payloads that use \n to delimit lines. However the spec also lists \r\n and \r as valid line separators. So support for these should be added to make the Arri clients more compliant with the SSE specification.

The chart below will track progress on this:

client finished
typescript ✅
rust ✅
dart ✅
kotlin ✅
@joshmossas joshmossas added bug Something isn't working codegen Issues related to generator plugins lang:rust lang:kotlin lang:dart lang:ts labels Jul 23, 2024
@joshmossas
Copy link
Member Author

Rust client now supports this as of #74

@joshmossas
Copy link
Member Author

Dart fixed by #93

@joshmossas
Copy link
Member Author

Completed in v0.61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working codegen Issues related to generator plugins lang:dart lang:kotlin lang:rust lang:ts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshmossas