Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsdom 23 unsupported #365

Closed
smhg opened this issue Dec 5, 2023 · 3 comments
Closed

jsdom 23 unsupported #365

smhg opened this issue Dec 5, 2023 · 3 comments

Comments

@smhg
Copy link
Contributor

smhg commented Dec 5, 2023

Is there any reason why jsdom >22 is not supported? I'm happy to create a PR to fix this.
@modosc
Copy link
Owner

modosc commented Dec 7, 2023

Is there any reason why jsdom >22 is not supported? I'm happy to create a PR to fix this.

no specific reason. a while back a jsdom release caused some breakage which is why i've been manually ratcheting this up.

pr would be welcome here.

@modosc
Copy link
Owner

modosc commented Dec 10, 2023

fixed in #366, will release a new version later today

@modosc modosc closed this as completed Dec 10, 2023
@smhg
Copy link
Contributor Author

smhg commented Dec 12, 2023

@modosc thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@modosc @smhg