Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install with Modrinth App is broken due to incorrect registry path #2274

Open
3 tasks done
Felix14-v2 opened this issue Aug 23, 2024 · 3 comments
Open
3 tasks done

Install with Modrinth App is broken due to incorrect registry path #2274

Felix14-v2 opened this issue Aug 23, 2024 · 3 comments
Labels
app Relates to Modrinth App bug Something isn't working

Comments

@Felix14-v2
Copy link

Felix14-v2 commented Aug 23, 2024

Please confirm the following.

  • I checked the existing issues for duplicate problems
  • I have tried resolving the issue using the support portal
  • I have ensured my Modrinth App installation is up to date

Info

  • Modrinth App 0.8.2
  • Windows 11

Description

The «Install with Modrinth App» button won't work if a path to the launcher .exe contains spaces:

Yet_another_broken_stuff.mp4

This happens due to incorrect registry path that Modrinth App sets on each launch (that's why I can't fix it myself):

Light theme alert! Actually this window doesn't support the dark theme at all, Windows sucks

image

To reproduce

  1. Create a user with a space in the name
  2. Install Modrinth App
  3. Try to install something from the website

Expected behavior

The path should be wrapped in quotation marks:
"C:\Users\Домашний компьютер\AppData\Local\Modrinth App\Modrinth App.exe" "%1"

After fixing the path manually the button works fine until the next App launch.

Additional context

Thread in Discord

@Felix14-v2 Felix14-v2 added app Relates to Modrinth App bug Something isn't working labels Aug 23, 2024
@Felix14-v2
Copy link
Author

Confirmed to be fixed in 0.8.5

@Felix14-v2
Copy link
Author

Felix14-v2 commented Sep 13, 2024

Confirmed to be broken again in 0.8.7 – App installs its update to a different directory (Program Files/Modrinth App instead of %LocalAppData%/Modrinth App) and doesn't update its location in the registry

@denisJaved
Copy link

denisJaved commented Sep 29, 2024

I'm also having similar path related issues, but with things like changing instance icon or adding non-modrinth mod through modrinth app. #2444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Relates to Modrinth App bug Something isn't working
Development

No branches or pull requests

2 participants