Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Minotaur fields are private marked despite being listed in readme as user facing #60

Closed
TelepathicGrunt opened this issue Nov 25, 2023 · 1 comment
Closed

Some Minotaur fields are private marked despite being listed in readme as user facing #60

TelepathicGrunt opened this issue Nov 25, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@TelepathicGrunt
Copy link

Describe the bug

Gradle produces warning that gameVersions and loaders are private fields in Minotaur
image

Can still build just file and upload through Minotaur.

Steps to reproduce

Make a project that sets the two fields like Bumblezone
https://github.com/TelepathicGrunt/Bumblezone/tree/1.20-Arch

Expected behavior

Fields are marked public if user facing as shown by the readme here:
https://github.com/modrinth/minotaur

Additional context

No response
@TelepathicGrunt TelepathicGrunt added the bug Something isn't working label Nov 25, 2023
@triphora
Copy link
Contributor

triphora commented Dec 3, 2023

This warning is entirely inaccurate, since Groovy converts it to using the get/set calls anyway... it's times like this I hate IntelliJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TelepathicGrunt @triphora