Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some GIFs are broken #1478

Closed
Felix14-v2 opened this issue Dec 5, 2023 · 2 comments · May be fixed by modrinth/omorphia#171
Closed

Some GIFs are broken #1478

Felix14-v2 opened this issue Dec 5, 2023 · 2 comments · May be fixed by modrinth/omorphia#171
Labels
bug Something isn't working web Relates to Modrinth.com web frontend

Comments

@Felix14-v2
Copy link

Felix14-v2 commented Dec 5, 2023 •
edited
Loading

Describe the bug

When browsing mods on some pages you can see the broken GIFs. For example, here – GIF just doesn't loaded. When opening it in separate tab you can see this error message:

{"status":"error","code":404,"message":"Input image exceeds pixel limit. Width x height should be less than 71000000"}

But the source page on GitHub displays GIF without any issues.

Steps to reproduce

  1. Open this page
  2. Find the broken GIF manually or paste this link into the URL field and go through it (this is due to another Modrinth bug that breaks these links by loading a page twice)
  3. See the error
  4. Open the gif in separate tab

Images

image

Additional

image
@Felix14-v2 Felix14-v2 added the bug Something isn't working label Dec 5, 2023
DAQEM referenced this issue in DAQEM/knossos Dec 20, 2023
@DAQEM
Added user-images.githubusercontent.com to allowed hostnames.
a851d21 
Added the hostname user-images.githubusercontent.com which is an official GitHub hostname to the allowed hostname list to resolve the issue where gifs larger than 71000000 pixels hosted on user-images.githubusercontent.com would fail to load because wsrv.nl doesn't allow gifs to be bigger than 71000000 pixels.

Closes #1468
@DAQEM DAQEM mentioned this issue Dec 20, 2023
Closed
@triphora triphora mentioned this issue Dec 20, 2023
Open
@Prospector Prospector transferred this issue from modrinth/knossos Aug 3, 2024
@Prospector Prospector added the web Relates to Modrinth.com web frontend label Aug 3, 2024
@Minenash
Copy link
Contributor

This doesn't happen in the link provided anymore, but that could be due to updating the image. That being said, (unless the error is wrong), the image would have had to be over 8426x8426 (or equivalent amount of pixels, like the error says). That is def too large to be using in a description

@Minenash Minenash closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2024
@Felix14-v2
Copy link
Author

Felix14-v2 commented Aug 31, 2024 •
edited
Loading

This doesn't happen in the link provided anymore, but that could be due to updating the image

Still happening for me
image

the image would have had to be over 8426x8426

But the GIF is 2554×1315 (5 387KB)
image

195899429-75fb0db4-a919-4a4b-bb0d-b7bb4c8b7222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working web Relates to Modrinth.com web frontend
Milestone
No milestone
3 participants
@Prospector @Minenash @Felix14-v2