fix: prevent module graph connection conflict #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I remove eager modules from remote, but in doing so also removes dependencies of delegate moduels, this preserves dependency tree of delegate module and removes all other eager references from eager:true
ScriptedAlchemy
added a commit
that referenced
this pull request
Jul 19, 2023
* fix: thrown error during chunk correlation of empty graph connection * fix: call of undefined errors in delegate modules * test: fix tests of delegate plugin * chore: prettier * refactor: improve package fragmentation re-export underlaying utilities to allow for less fragmentation of package versions for the sake of access to these tools * fix: prevent module graph connection conflict (#1151) * fix: prevent module graph connection conflict I remove eager modules from remote, but in doing so also removes dependencies of delegate moduels, this preserves dependency tree of delegate module and removes all other eager references from eager:true * test: fix mock of delegate module eager flag * test: fix mock of delegate module eager flag * test: fix mock of delegate module eager flag * feat: support next/image * style:lint fix * style:lint fix * style:lint fix
RussellCanfield
pushed a commit
to RussellCanfield/nextjs-mf
that referenced
this pull request
Aug 26, 2023
* fix: thrown error during chunk correlation of empty graph connection * fix: call of undefined errors in delegate modules * test: fix tests of delegate plugin * chore: prettier * refactor: improve package fragmentation re-export underlaying utilities to allow for less fragmentation of package versions for the sake of access to these tools * fix: prevent module graph connection conflict (module-federation#1151) * fix: prevent module graph connection conflict I remove eager modules from remote, but in doing so also removes dependencies of delegate moduels, this preserves dependency tree of delegate module and removes all other eager references from eager:true * test: fix mock of delegate module eager flag * test: fix mock of delegate module eager flag * test: fix mock of delegate module eager flag * feat: support next/image * style:lint fix * style:lint fix * style:lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remove eager modules from remote, but in doing so also removes dependencies of delegate moduels, this preserves dependency tree of delegate module and removes all other eager references from eager:true