-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@module-federation/typescript 2.0.3
cause html-webpack-plugin
throw Error: Child compilation has already started
#455
Comments
Hey @liaoyu, I'm developing a plugin for this that is bundler-agnostic: https://github.com/ilteoood/native-federation-typescript If you have some time, would you like to test it? |
👀 I'm also running into this issue |
@dmcgoughpax8 may I ask you to test my plugin too? More details in previous comments |
* Remove module side effects * Remove var * fix(typescript): generated types doesn't get included in types index (#487) * fix(typescript): defined exposes declaration files now consumable * fix(typescript): generateTypesStats now accounts for absolute paths when setting filename * fix: [node] build error when no remotes are used (#500) * fix(federatedtypesplugin): modify remote url used to import remote types (#496) url derived from remote components urls previously failed when fetching types when package has an organization scope. by taking the split index and taking a substring of the remote url at that index fixes this issue fix #495 Co-authored-by: Zack Jackson <zackary.l.jackson@gmail.com> * feat: [node] build error when no remotes are used * chore(node): release version 0.10.0 * chore(nextjs-mf): release version 6.0.2 * fix(typescript): unable to download types from multiple remotes (#492) fixes #455 * Utilities - add license information (#491) * add license information to utilities * Utilities - Add LICENSE file Co-authored-by: Zack Jackson <zackary.l.jackson@gmail.com> * Regen lock file * fix(federatedtypesplugin): modify remote url used to import remote types (#496) url derived from remote components urls previously failed when fetching types when package has an organization scope. by taking the split index and taking a substring of the remote url at that index fixes this issue fix #495 Co-authored-by: Zack Jackson <zackary.l.jackson@gmail.com> Co-authored-by: dmcgoughpax8 <dmcgough@pax8.com> Co-authored-by: Zack Jackson <zackary.l.jackson@gmail.com> Co-authored-by: Austin Howard <ahoward@austinhoward.tech> Co-authored-by: GitHub Bot <gituser@example.com> Co-authored-by: jon <jonathanceddy@gmail.com>
🎉 This issue has been resolved in version 1.0.0-canary.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
html-webpack-plugin
throw:Only when
remotes
have multi app will cause this error,Ifremotes
only hasapp2
it works.Analysis of causes
Child compilation has already started
ref: https://github.com/jantimon/html-webpack-plugin/blob/d5ce5a8f2d12a2450a65ec51c285dd54e36cd921/lib/cached-child-compiler.js#L182-L187Possibly reason is webpack callback invoked many times.
https://github.com/module-federation/universe/blob/d97d764ded8d3cb1b5e04829eaf226f0c5a3baa3/packages/typescript/src/plugins/FederatedTypesPlugin.ts#L204-L207
Reappearance Env
Reappearance demo: https://github.com/liaoyu/module-federation-typescript-v2-issue-reappearance
The text was updated successfully, but these errors were encountered: