feat: Utilities - Add async callback to importRemote #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussellCanfield
changed the title
|
Looks good. Nice addition with the url promise function option! |
pavandv
suggested changes
Dec 28, 2022
…sitive file systems (module-federation#451) * fix(typescript): compiler output folder structure * chore: finalise * docs: update readme * docs: update typescript readme * chore(typescript): cleanup - addressing comments Co-authored-by: DV <pavan.divi@outlook.com> Co-authored-by: Zack Jackson <zackary.l.jackson@gmail.com>
pavandv
approved these changes
Dec 28, 2022
|
ensure running nx build locally works and the next.js applications build without issue |
Thanks @ScriptedAlchemy - I saw you fixed a typing issue I introduced. I was able to successfully run:
without any issues |
ScriptedAlchemy
approved these changes
Dec 29, 2022
ScriptedAlchemy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the url parameter for the importRemote function to be a static string or an async callback to fetch a URL. Additionally it ports over the readme section from the utilities repo.
@alex-vukov - would you mind reviewing?