ci: git tags should match with release versions #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavandv
changed the title
RussellCanfield
pushed a commit
to RussellCanfield/nextjs-mf
that referenced
this pull request
Dec 28, 2022
ScriptedAlchemy
added a commit
that referenced
this pull request
Dec 29, 2022
* Add async callback to importRemote * Update readme * chore(utils): release version 1.0.3 * chore(node): release version 0.9.9 * chore(typescript): release version 2.1.1 * chore(nextjs-mf): release version 5.12.14 * ci: git tags should match with release versions (#461) * fix(typescript): compiler host re-writes compiled files in case-insensitive file systems (#451) * fix(typescript): compiler output folder structure * chore: finalise * docs: update readme * docs: update typescript readme * chore(typescript): cleanup - addressing comments Co-authored-by: DV <pavan.divi@outlook.com> Co-authored-by: Zack Jackson <zackary.l.jackson@gmail.com> * chore: update nx to latest version (#463) * Fix readme Co-authored-by: Zack Jackson <zackary.l.jackson@gmail.com> Co-authored-by: GitHub Bot <gituser@example.com> Co-authored-by: Kyle Tsang <6854874+kyletsang@users.noreply.github.com> Co-authored-by: Haydon Lam <58468238+hongkiulam@users.noreply.github.com> Co-authored-by: DV <pavan.divi@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #460
I suspect the issue may be caused because the npm release process is depending on a build output that doesn't factor in the package version uprev and the newly built dependent packages. The current GHA builds the library in the
Buildstep beforenodeandutilitiesare built in theVersionstep, which I believe is causing the dependency mismatch.