feat: add getModule and getContainer to utilities #476
Conversation
| if (!modFactory) return undefined; | ||
| const mod = modFactory(); | ||
| if (exportName) { | ||
| return mod && typeof mod === 'object' ? mod[exportName] : undefined; |
There was a problem hiding this comment.
Can we use optional chaining and nullish coalescing?
There was a problem hiding this comment.
@ExProbitasFiducia in fact i only had isolate the source code and bring to the utilities, i haven't develop the code 😅
@ScriptedAlchemy using optional chaining and nullish coalescing here would have the same effect or you had avoided to use because you've found any problem?
There was a problem hiding this comment.
See if it compiles down to ES5 or not, if it keeps the modern syntax then id avoid using it since it will break some browsers / node versions
There was a problem hiding this comment.
It *should* according to this SO post, but it could be down to config; it depends what the target we're compiling to is. If we're targeting es5 in our config then it ought to work though; full disclosure I have not checked that nor have I looked at the config.
|
Lint fail in CI |
…iverse into feat/get-module-to-utilities
|
@ScriptedAlchemy i merge and fix conflicts and run nx lint now 🙏🏻 |
As state at the discussion #399