Feat: container inversion for server #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ScriptedAlchemy
commented
Apr 25, 2023
•
ScriptedAlchemy
commented
- Container inversion in server
- re-implement module hoisting design
- new snapshots and tests
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| @@ -49,7 +49,7 @@ const nextConfig = { | |||
| }, | |||
| shared: { | |||
| // lodash: {}, | |||
| // antd: {}, | |||
| antd: {}, | |||
| }, | |||
| extraOptions: { | |||
| automaticAsyncBoundary: true, | |||
There was a problem hiding this comment.
The code patch is very short and doesn't have any apparent bugs or risks. It simply comments out the lodash library from being shared and enables sharing of the antd library. However, it's difficult to assess the quality of the code without further context or information about the purpose and requirements of this code patch.
package-lock.json
Outdated
| @@ -34262,7 +34267,8 @@ | |||
| "version": "file:dist/packages/utilities", | |||
| "requires": { | |||
| "next": "13.3.0", | |||
| "react": "18.2.0" | |||
| "react": "18.2.0", | |||
| "webpack-sources": "3.2.3" | |||
| } | |||
| }, | |||
| "@mole-inc/bin-wrapper": { | |||
There was a problem hiding this comment.
This code is a patch that adds "webpack-sources": "3.2.3" as a dependency to three different packages in a project. The change seems reasonable and there are no obvious bug risks. One potential improvement could be to provide a justification for why the webpack-sources package was added as a dependency, so that future maintainers can understand the reasoning behind the change.
* working on share scope resetting during hmr * fix: address destructive share scope operations on hmr * fix: duplicate share key in scope * fix: module sharing without eager entry bloat
…oisting # Conflicts: # packages/nextjs-mf/__snapshots__/chunk-intergration.test.ts.snap
ScriptedAlchemy
added a commit
that referenced
this pull request
Apr 27, 2023
* fix: improve module chunk graph connections * feat: DelegateModulePlugin (#803) * refactor: stage back module classification Adding new utility plugin for delegate modules * chore: clean up unused modules * Feat: container inversion for server (#808) * test: add InvertedContainerPlugin * chore: enable sharing again * fix: HMR deletes share scope (#811) * working on share scope resetting during hmr * fix: address destructive share scope operations on hmr * fix: duplicate share key in scope * fix: module sharing without eager entry bloat
ScriptedAlchemy
added a commit
that referenced
this pull request
Apr 27, 2023
* fix: improve module chunk graph connections * feat: DelegateModulePlugin (#803) * refactor: stage back module classification Adding new utility plugin for delegate modules * chore: clean up unused modules * Feat: container inversion for server (#808) * test: add InvertedContainerPlugin * chore: enable sharing again * fix: HMR deletes share scope (#811) * working on share scope resetting during hmr * fix: address destructive share scope operations on hmr * fix: duplicate share key in scope * fix: module sharing without eager entry bloat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.