utils - 'os' dependency started to be required

[tadayosi]

After upgrading @module-federation/utilities from 1.6.0 to 1.7.0, I started to see the following error while building my CRA / CRACO app. Is this an expected change? i.e. starting from 1.7.0, is either installing 'os-browserify' or suppressing 'os' required?

[app]: Process started
[app]: Creating an optimized production build...
[app]: Failed to compile.
[app]: 
[app]: Module not found: Error: Can't resolve 'os' in '/home/runner/work/hawtio-next/hawtio-next/node_modules/@module-federation/utilities/src/utils'
[app]: BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
[app]: This is no longer the case. Verify if you need this module and configure a polyfill for it.
[app]: 
[app]: If you want to include a polyfill, you need to:
[app]: 	- add a fallback 'resolve.fallback: { "os": require.resolve("os-browserify/browser") }'
[app]: 	- install 'os-browserify'
[app]: If you don't want to include a polyfill, you can use an empty module like this:
[app]: 	resolve.fallback: { "os": false }
[app]: 
[app]: 
[app]: Process exited (exit code 1), completed in 30s 754ms

[spnc-omz]

Seems related to the addition of correctImportPath.js

https://github.com/module-federation/universe/pull/598/files#diff-4f6f587b9c06f7af513a637c65b67ffe91616577937caa4b89d93047c9468e97

@fyodorovandrei

[fyodorovandrei]

I will investigate this issue, but I can suggest a workaround:

• Install packages: yarn add os-browserify path-browserify
• Update config (craco.config.js)

  module.exports = {
    webpack: {
      // ...
      configure: webpackConfig => {
        // ...
        webpackConfig['resolve'] = {
          fallback: {
            path: require.resolve("path-browserify"),
            os: require.resolve("os-browserify")
          },
        }
        // ...
        return webpackConfig
      },
      // ...
    },
  }

[wmain]

@fyodorovandrei / @ilteoood This fix hasn't been released, correct?

[fyodorovandrei]

@wmain Yes. @ScriptedAlchemy Do you have any idea when will be published the next version?

[ScriptedAlchemy]

I'll cut one tomorrow ❤️

[efriandika]

I still have this issue in v1.8.0

ERROR in ../../node_modules/@module-federation/utilities/src/utils/correctImportPath.js 15:13-28