Fix bank account refund

Author: caiogaspar

src/Resource/Refund.php

@@ -146,7 +146,7 @@ private function getPath()
     /**
      * Bank account is the bank address of a particular vendor or a customer.
      *
-     * @param string                  $type               Kind of refund. possible values: FULL, PARTIAL.
+     * @param string                  $type               Kind of bank account. possible values: CHECKING, SAVING.
      * @param string                  $bankNumber         Bank number. possible values: 001, 237, 341, 041.
      * @param int                     $agencyNumber       Branch number.
      * @param int                     $agencyCheckNumber  Checksum of the agency.
@@ -159,27 +159,28 @@ private function getPath()
     private function bankAccount($type, $bankNumber, $agencyNumber, $agencyCheckNumber, $accountNumber, $accountCheckNumber, Customer $holder)
     {
         $data = new stdClass();
-        $data->refundingInstrument = self::METHOD_BANK_ACCOUNT;
-        $data->bankAccount = new stdClass();
-        $data->bankAccount->type = $type;
-        $data->bankAccount->bankNumber = $bankNumber;
-        $data->bankAccount->agencyNumber = $agencyNumber;
-        $data->bankAccount->agencyCheckNumber = $agencyCheckNumber;
-        $data->bankAccount->accountNumber = $accountNumber;
-        $data->bankAccount->accountCheckNumber = $accountCheckNumber;
-        $data->bankAccount->holder = new stdClass();
-        $data->bankAccount->holder->fullname = $holder->getFullname();
-        $data->bankAccount->holder->taxDocument = new stdClass();
-        $data->bankAccount->holder->taxDocument->type = $holder->getTaxDocumentType();
-        $data->bankAccount->holder->taxDocument->number = $holder->getTaxDocumentNumber();
+        $data->refundingInstrument = new stdClass(); 
+        $data->refundingInstrument->method= self::METHOD_BANK_ACCOUNT;
+        $data->refundingInstrument->bankAccount = new stdClass();
+        $data->refundingInstrument->bankAccount->type = $type;
+        $data->refundingInstrument->bankAccount->bankNumber = $bankNumber;
+        $data->refundingInstrument->bankAccount->agencyNumber = $agencyNumber;
+        $data->refundingInstrument->bankAccount->agencyCheckNumber = $agencyCheckNumber;
+        $data->refundingInstrument->bankAccount->accountNumber = $accountNumber;
+        $data->refundingInstrument->bankAccount->accountCheckNumber = $accountCheckNumber;
+        $data->refundingInstrument->bankAccount->holder = new stdClass();
+        $data->refundingInstrument->bankAccount->holder->fullname = $holder->getFullname();
+        $data->refundingInstrument->bankAccount->holder->taxDocument = new stdClass();
+        $data->refundingInstrument->bankAccount->holder->taxDocument->type = $holder->getTaxDocumentType();
+        $data->refundingInstrument->bankAccount->holder->taxDocument->number = $holder->getTaxDocumentNumber();
 
         return $data;
     }
 
     /**
      * Making a full refund to the bank account.
      *
-     * @param string                  $type               Kind of refund. possible values: FULL, PARTIAL.
+     * @param string                  $type               Kind of bank account. possible values: CHECKING, SAVING.
      * @param string                  $bankNumber         Bank number. possible values: 001, 237, 341, 041.
      * @param int                     $agencyNumber       Branch number.
      * @param int                     $agencyCheckNumber  Checksum of the agency.
@@ -199,7 +200,7 @@ public function bankAccountFull($type, $bankNumber, $agencyNumber, $agencyCheckN
     /**
      * Making a partial refund in the bank account.
      *
-     * @param string                  $type               Kind of refund. possible values: FULL, PARTIAL.
+     * @param string                  $type               Kind of bank account. possible values: CHECKING, SAVING.
      * @param string                  $bankNumber         Bank number. possible values: 001, 237, 341, 041.
      * @param int                     $agencyNumber       Branch number.
      * @param int                     $agencyCheckNumber  Checksum of the agency.

tests/Resource/RefundTest.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace Moip\Tests\Resource;
+
+use Moip\Tests\TestCase;
+
+class RefundTest extends TestCase
+{
+
+    public function testRefundBankAccountFull() {
+        $this->mockHttpSession($this->body_order);
+        $order = $this->createOrder()->create();
+        $this->mockHttpSession($this->body_billet_pay);
+        $payment = $order->payments()->get('PAY-N2TXFLV4PP7Y'); 
+        $this->mockHttpSession($this->body_refund_full_bankaccount);
+        $refund = $payment->refunds()
+            ->bankAccountFull('CHECKING', '001', '1584', '9', '00210169', '6', $order->getCustomer());
+        $this->assertNotEmpty($refund->getId());
+    }
+    
+    public function testRefundBankAccountPartial() {
+        $this->mockHttpSession($this->body_order);
+        $order = $this->createOrder()->create();
+        $this->mockHttpSession($this->body_billet_pay);
+        $payment = $order->payments()->get('PAY-N2TXFLV4PP7Y'); 
+        $this->mockHttpSession($this->body_refund_partial_bankaccount);
+        $refund = $payment->refunds()
+            ->bankAccountPartial(20000, 'SAVING','001', '1584', '9', '00210169', '6', $order->getCustomer());
+        $this->assertNotEmpty($refund->getId());
+    }
+}

tests/TestCase.php

@@ -61,7 +61,17 @@ abstract class TestCase extends PHPUnit_Framework_TestCase
      * @var string response from moip API.
      */
     protected $body_billet_pay = '{"id":"PAY-XNVIBO5MIQ9S","status":"WAITING","delayCapture":false,"amount":{"total":102470,"fees":3645,"refunds":0,"liquid":98825,"currency":"BRL"},"installmentCount":1,"fundingInstrument":{"boleto":{"expirationDate":"2016-05-21","lineCode":"23793.39126 60000.062608 32001.747909 7 68010000102470"},"method":"BOLETO"},"fees":[{"type":"TRANSACTION","amount":3645}],"events":[{"type":"PAYMENT.CREATED","createdAt":"2016-05-20T15:19:47.000-03"},{"type":"PAYMENT.WAITING","createdAt":"2016-05-20T15:19:47.000-03"}],"_links":{"order":{"href":"https://sandbox.moip.com.br/v2/orders/ORD-3KSQDBJSTIF6","title":"ORD-3KSQDBJSTIF6"},"payBoleto":{"redirectHref":"https://checkout-sandbox.moip.com.br/boleto/PAY-XNVIBO5MIQ9S"},"self":{"href":"https://sandbox.moip.com.br/v2/payments/PAY-XNVIBO5MIQ9S"}},"updatedAt":"2016-05-20T15:19:47.000-03","createdAt":"2016-05-20T15:19:47.000-03"}';
+    
+    /**
+     * @var string response from moip API.
+     */
+    protected $body_refund_full_bankaccount = '{"id":"REF-F60THFADO8N4","status":"REQUESTED","events":[{"type":"REFUND.REQUESTED","createdAt":"2017-06-27T08:52:36.000-03"}],"amount":{"total":45000,"fees":0,"currency":"BRL"},"type":"FULL","refundingInstrument":{"bankAccount":{"bankNumber":"001","bankName":"BANCO DO BRASIL S.A.","agencyNumber":"1584","agencyCheckNumber":"9","accountNumber":"00210169","accountCheckNumber":"6","type":"CHECKING","holder":{"taxDocument":{"type":"CPF","number":"22222222222"},"fullname":"Fulano de Tal"}},"method":"BANK_ACCOUNT"},"createdAt":"2017-06-27T08:52:36.000-03","_links":{"self":{"href":"https://sandbox.moip.com.br/v2/refunds/REF-F60THFADO8N4"},"order":{"href":"https://sandbox.moip.com.br/v2/orders/ORD-KNCJJINLN9QL","title":"ORD-KNCJJINLN9QL"},"payment":{"href":"https://sandbox.moip.com.br/v2/payments/PAY-WRZLMJ8JZA9Q","title":"PAY-WRZLMJ8JZA9Q"}}}';
 
+    /**
+     * @var string response from moip API.
+     */
+    protected $body_refund_partial_bankaccount = '{"id":"REF-0R8FSCPTI5IS","status":"REQUESTED","events":[{"type":"REFUND.REQUESTED","createdAt":"2017-06-27T11:27:56.000-03"}],"amount":{"total":20000,"fees":0,"currency":"BRL"},"type":"PARTIAL","refundingInstrument":{"bankAccount":{"bankNumber":"001","bankName":"BANCO DO BRASIL S.A.","agencyNumber":"1584","agencyCheckNumber":"9","accountNumber":"00210169","accountCheckNumber":"6","type":"SAVING","holder":{"taxDocument":{"type":"CPF","number":"22222222222"},"fullname":"Fulano de Tal"}},"method":"BANK_ACCOUNT"},"createdAt":"2017-06-27T11:27:56.000-03","_links":{"self":{"href":"https://sandbox.moip.com.br/v2/refunds/REF-0R8FSCPTI5IS"},"order":{"href":"https://sandbox.moip.com.br/v2/orders/ORD-0HX56ERCBKWE","title":"ORD-0HX56ERCBKWE"},"payment":{"href":"https://sandbox.moip.com.br/v2/payments/PAY-1177YNDVSO7W","title":"PAY-1177YNDVSO7W"}}}';
+    
     /**
      * @var string holds the last generated customer ownId. In mock mode it'll be always the default, but it changes on sandbox mode.
      */