Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new linker._supports_seed method #1325

Open
ThomasHepworth opened this issue Jun 13, 2023 · 0 comments
Open

Create new linker._supports_seed method #1325

ThomasHepworth opened this issue Jun 13, 2023 · 0 comments
Labels

Comments

@ThomasHepworth
Copy link
Contributor

An extension of #1161.

If a specific backend doesn't support random seeds, I think it makes more sense to exit at the start of a given method, rather than halfway through the execution.

For example, the sqlite linker will only halt execution when it reaches _random_sample_sql, but it should probably exit at the start of the u training step.

Yeah I think that would be useful - same applies to `sqlite`. Maybe need to end up with `linker._supports_seed` or something

Originally posted by @ADBond in #1251 (comment)

@ThomasHepworth ThomasHepworth added enhancement New feature or request good first issue Good for newcomers nice to have and removed enhancement New feature or request labels Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant