Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add GitHub action to sort/update custom dictionary #2100

Closed
zslade opened this issue Mar 27, 2024 · 3 comments
Closed

[FEAT] Add GitHub action to sort/update custom dictionary #2100

zslade opened this issue Mar 27, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request spellchecker

Comments

@zslade
Copy link
Contributor

zslade commented Mar 27, 2024

Is your proposal related to a problem?

custom_dictionary.txt is updated as part of the manual spellchecking process but it's time consuming to add words in alphabetical order.

Related to PR: #2025

Describe the solution you'd like

Set up a GitHub Action to automatically alpha-sort the custom dictionary when updates to it are merged into master and/or splink4_dev.
Removing duplicates from the dictionary could also be done as part of this Action.

This information also needs to be reflected in the documentation on using the spellchecker.

Describe alternatives you've considered

Additional context

@zslade zslade added the enhancement New feature or request label Mar 27, 2024
@zslade zslade self-assigned this Mar 27, 2024
@ThomasHepworth ThomasHepworth self-assigned this Mar 27, 2024
@RobinL
Copy link
Member

RobinL commented Apr 17, 2024

I think this is possibly overkill in terms of infra complexity given that an unsorted file doesn't actually break anything

When I added some terms I used the sort command in vs code:
image

@zslade
Copy link
Contributor Author

zslade commented Apr 17, 2024

Makes sense, thank you. Happy for this issue to be closed and I can just update the docs accordingly 👍

@RobinL
Copy link
Member

RobinL commented Apr 17, 2024

thank you! (sorry was just doing a bit of a more general issue review this morning and spotted this one )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spellchecker
Projects
None yet
Development

No branches or pull requests

3 participants