Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mojaloop/3347): enhance the request to pay transfer api process for payer acceptance flow #163

Merged
merged 15 commits into from
Jun 5, 2023
Merged

feat(mojaloop/3347): enhance the request to pay transfer api process for payer acceptance flow #163

merged 15 commits into from
Jun 5, 2023

Conversation

vijayg10
Copy link
Contributor

@vijayg10 vijayg10 commented May 25, 2023 •
edited
Loading

feat(mojaloop/3347): enhance the request to pay transfer api process for payer acceptance flow

Changes:

SDK Backend API:

  • Added homeR2PTransactionId and transactionRequestId to POST /quoteRequest
  • Added homeR2PTransactionId to POST /transfers
  • Added new API resource PUT /requestToPay/{transactionRequestId}

SDK Outbound API:

  • Changed requestToPayTransactionId to transactionRequestId in PUT /requestToPayTransfer
  • Added homeR2PTransactionId and transactionRequestId to requestToPayTransferRequest
  • Fixed schema for scenario field in requestToPayTransferRequest
  • Added authenticationType to requestToPayTransferRequest
  • Changed requestToPayTransactionId to transactionRequestId in requestToPayTransferResponse
  • Added homeR2PTransactionId to requestToPayTransferResponse
  • Fixed schema of quoteResponse in requestToPayTransferResponse
  • Added authorizationResponse to requestToPayTransferResponse
  • Fixed schema of fulfil in requestToPayTransferResponse

@vijayg10 vijayg10 requested a review from kleyow as a code owner May 25, 2023 16:57
@vijayg10 vijayg10 self-assigned this May 25, 2023
@vijayg10 vijayg10 mentioned this pull request May 25, 2023
Closed
34 tasks
mdebarros
mdebarros reviewed May 26, 2023
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

But perhaps you missed two updates? See comment below.

docs/sdk-scheme-adapter-outbound-v2_0_0-openapi3-snippets.yaml Show resolved Hide resolved
@vijayg10 vijayg10 requested a review from mdebarros June 5, 2023 10:16
vijayg10 and others added 3 commits June 5, 2023 16:44
@vijayg10 @mdebarros
Update docs/sdk-scheme-adapter-outbound-v2_0_0-openapi3-snippets.yaml
78a888e 
Co-authored-by: Miguel de Barros <miguel@debarros.me>
@vijayg10 @mdebarros
Update docs/sdk-scheme-adapter-outbound-v2_0_0-openapi3-snippets.yaml
8295915 
Co-authored-by: Miguel de Barros <miguel@debarros.me>
@vijayg10 @mdebarros
Update docs/sdk-scheme-adapter-outbound-v2_0_0-openapi3-snippets.yaml
90718f7 
Co-authored-by: Miguel de Barros <miguel@debarros.me>
@vijayg10 vijayg10 merged commit d24c889 into master Jun 5, 2023
@vijayg10 vijayg10 deleted the feat/#3347-Enhance-the-requestToPayTransfer-API-process-for-Payer-Acceptance-flow branch June 5, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebarros mdebarros mdebarros approved these changes

@kleyow kleyow Awaiting requested review from kleyow

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

@lewisdaly lewisdaly Awaiting requested review from lewisdaly

@kirgene kirgene Awaiting requested review from kirgene

Assignees

@vijayg10 vijayg10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vijayg10 @mdebarros