Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disconnect the EventEmitter #136

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix: disconnect the EventEmitter #136

merged 1 commit into from
Mar 15, 2024

Conversation

kalinkrustev
Copy link
Contributor

@kalinkrustev kalinkrustev commented Mar 15, 2024 •
edited
Loading

Found a better disconnect method within the class, so better use it to call the downstream one.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kalinkrustev kalinkrustev requested a review from kleyow March 15, 2024 20:18
@kalinkrustev kalinkrustev merged commit d1cdab6 into master Mar 15, 2024
10 checks passed
@kalinkrustev kalinkrustev deleted the graceful-exit branch March 15, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleyow kleyow kleyow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalinkrustev @kleyow