Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement repetitive build jobs in a central place #38

Closed
kalinkrustev opened this issue May 14, 2024 · 7 comments
Closed

Implement repetitive build jobs in a central place #38

kalinkrustev opened this issue May 14, 2024 · 7 comments
Assignees

Comments

@kalinkrustev
Copy link

No description provided.

@kalinkrustev
Copy link
Author

An example is the code added for publish-prerelease in mojaloop/central-services-stream#141, but also many other jobs in the same .circleci/config.yml file

@kalinkrustev kalinkrustev self-assigned this May 14, 2024
@kalinkrustev
Copy link
Author

@elnyry-sam-k , what do you think of the idea of having the build jobs in a central place?

I prepared a draft orb here #39, it is based on jobs taken from central-ledger with added one more job for publishing the pre-release branches.

Repos can start reusing the jobs gradually unless they need something specific.

@elnyry-sam-k
Copy link
Member

DRY, lets do it!!

Thanks for this, @kalinkrustev

@kalinkrustev
Copy link
Author

@elnyry-sam-k actually putting multiple orbs in one repo is not a good idea, as the automation that Circle CI provides for publishing orbs is not convenient for such case. Can I create a new repo for the build orb? Maybe mojaloop/orb-build ?

@elnyry-sam-k
Copy link
Member

ok, is something like ci-config-orb-build ok?

@kalinkrustev
Copy link
Author

Moved to mojaloop/ci-config-orb-build#1

@elnyry-sam-k, as per this permissions matrix, I think I will need the mojaloop github org owner to create the orb mojaloop/build or to set the CIRCLE_TOKEN in this context https://app.circleci.com/settings/organization/github/mojaloop/contexts/1d64c5ff-d141-4bc2-9ccb-4c4ae3169041, so that orbs can be published automatically.

Currently I can't publish even a dev release, as the orb mojaloop/build does not exist.

@elnyry-sam-k
Copy link
Member

reached out on slack, lets sort it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants