feat(mbp/#286): add simulator rule to trigger patch transferState=aborted notification #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibaros
changed the title
gibaros
changed the title
gibaros
changed the title
gibaros
changed the title
mdebarros
requested changes
May 17, 2022
mdebarros
reviewed
May 17, 2022
mdebarros
reviewed
May 17, 2022
mdebarros
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to the POST /transfers Swagger definition 3 new fields on its response; fulfilment, transferState or completedTimestamp to enable automation of negative scenarios. Now mojaloop-simulator can add rules where any of these 3 fields can be overriden to trigger negative scenarios. The negative scenario of interest and the one enabled by the POST /transfers rule added on this PR is in the case an invalid fulfilment is returned by the backend so it can be relayed by the mojaloop-connector to the Mojaloop Hub so upon fulfilment validation fails and triggers a PATCH transferState=ABORTED notification.