Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mojaloop/#2928): upgrade logger to central-services-logger #148

Merged
merged 25 commits into from
Nov 17, 2022
Merged

feat(mojaloop/#2928): upgrade logger to central-services-logger #148

merged 25 commits into from
Nov 17, 2022

Conversation

kleyow
Copy link
Contributor

@kleyow kleyow commented Nov 2, 2022 •
edited
Loading

feat(mojaloop/#2928): upgrade logger to central-services-logger - mojaloop/project#2928

  • Switch lib logger to central services logger
  • Improve testing and coverage
  • Update dep
  • Switch tests to serial to squash conflict with sinon stubbing
  • Reduce logger noise by setting health endpoint logs to debug

@kleyow kleyow changed the title feat: upgrade logger to central-services-logger feat(mojaloop/#2928): upgrade logger to central-services-logger Nov 2, 2022
@kleyow kleyow marked this pull request as ready for review November 2, 2022 03:01
kleyow
kleyow commented Nov 15, 2022
View reviewed changes
src/index.js Show resolved Hide resolved
mdebarros
mdebarros requested changes Nov 17, 2022
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor suggestion change.

Let me know if you agree.

src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
@kleyow @mdebarros
Apply suggestions from code review
9e707b6 
Co-authored-by: Miguel de Barros <miguel@debarros.me>
mdebarros
mdebarros previously approved these changes Nov 17, 2022
View reviewed changes
@kleyow kleyow merged commit 8a1573e into mojaloop:master Nov 17, 2022
@kleyow kleyow deleted the feat/logging branch November 17, 2022 18:26
@kleyow kleyow mentioned this pull request Nov 22, 2022
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elnyry-sam-k elnyry-sam-k elnyry-sam-k approved these changes

@mdebarros mdebarros mdebarros left review comments

@vijayg10 vijayg10 Awaiting requested review from vijayg10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kleyow @elnyry-sam-k @mdebarros