Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing trace tags in cl timeout handler trace messages #1034

Closed
10 of 11 tasks
vgenev opened this issue Oct 25, 2019 · 0 comments
Closed
10 of 11 tasks

Missing trace tags in cl timeout handler trace messages #1034

vgenev opened this issue Oct 25, 2019 · 0 comments
Assignees
Milestone

Comments

@vgenev
Copy link

vgenev commented Oct 25, 2019

Summary:
In the event trace messages from the central-ledger timeout handlerTags no tags have been added. Thus master span rules for ending the span cannot be applied. The rules rely on transactionType and transactionAction tags, as well as the service name.
Also the consecutive spans (position, notification) are from different trace.

Severity:
Medium

Priority:
Low

Expected Behavior
Every trace-span event message should have following tags:

"tags": {
  "transactionType": "transfer",
  "transactionAction": "prepare",
  "transactionId": "69a205bc-6b12-466a-9be4-575cb14fa30e",
  "source": "payerfsp",
  "destination": "payeefsp",
  "payerFsp": "payerfsp", 
  "payeeFsp": "payeefsp"
}

as payerFsp and payeeFsp, if applicable.

Steps to Reproduce

  1. Create a transfer
  2. Wait for transfer to expire
  3. Check the event message

Tasks

  • Update central-services-shared to add getTransferSpanTags helper method to be able to use it in both central-ledger and ml-api-adapter
  • Update central-ledger timeout handler to add tags using the shared function and pass span context to the message so prepare handler and ml-notification-handler to fall into the same trace
  • Update ml-api-adapter to use the shared function
  • Update event-streaming-processor default.json to cover start and end criteria for the span from timeout handler
  • Update default.json in helm chart for event-streaming-processor

Pull Requests

Dependencies

Specifications

  • Component (if known): Central Ledger timeout handler
  • Version: latest
  • Bug found/raised by: @vgenev

Notes:
At the moment in the event-streaming-processor the cl timeout handler span is closed as a single trace. This needs to be fixed as soon as the bug is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants