Unit tests for central-settlement, part 1

[ggrg]

Goal:

As a Mojaloop contributor
I want to add unit tests to central-settlement, branch settlement-v2
so that full coverage is achieved for newly introduced functionality

Tasks:

• Unit tests to cover the following modules:
  • src/api/index.js @bothadeon
  • src/domain/settlementWindow/index.js @bothadeon
  • src/handlers/index.js @bothadeon
  • src/handlers/register.js @bothadeon
  • src/lib/healthCheck/subServiceHealth.js @bothadeon
  • src/handlers/settlementWindow/handler.js @lazolalucas
  • src/models/settlementWindow/facade.js @bothadeon
  • src/shared/setup.js @bothadeon

Acceptance Criteria:

• Unit Tests pass
• Coverage meets standards

Pull Requests:

• Settlement v2 deon central-settlement#234

Follow-up:

• Request Settlement by Currency Wrap-up and QA #1100

Dependencies:

• Implement changes related to closeSettlementWindow #1095

Accountability:

• Owner: @ggrg
• QA/Review: @ggrg

[ggrg]

Current state:

=============================== Coverage summary ===============================
Statements   : 88.73% ( 1134/1278 )
Branches     : 87.77% ( 366/417 )
Functions    : 89.22% ( 149/167 )
Lines        : 88.5% ( 1101/1244 )
================================================================================

[bothadeon]

Current state at the end of Tuesday 14 Jan 2020:

========================= Coverage summary ============================
Statements  : 90.76% ( 1159/1277 )
Branches    : 89.45% ( 373/417 )
Functions   : 90.42% ( 151/167 )
Lines       : 90.51% ( 1125/1243 )
=======================================================================