Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoting Service POST /quotes allows empty quoteId and transactionId #1172

Closed
4 tasks done
ndonnan opened this issue Jan 16, 2020 · 1 comment
Closed
4 tasks done

Quoting Service POST /quotes allows empty quoteId and transactionId #1172

ndonnan opened this issue Jan 16, 2020 · 1 comment
Assignees
Milestone

Comments

@ndonnan
Copy link

ndonnan commented Jan 16, 2020

Summary:
The quoting-service POST /quotes endpoint allows empty quoteId and transactionId values.

These are marked as mandatory in the swagger definition and have patterns, however a "minLength" of 1 is required in order to validate empty values being sent in these fields.

Tasks:

  • Validate the changes
  • Make sure test added to postman test collection

NOTE: This is due to an underlying bug in enjoi, PR raised here: tlivings/enjoi#73

Once the above PR is merged the "minLength" should be removed from the quoting-service swagger.json!

Severity:
Low

Priority:
Low

Expected Behavior
An error message is returned if an empty value is passed for these fields:
quoteId:

{
    "errorInformation": {
        "errorCode": "3102",
        "errorDescription": "Missing mandatory element - \"QuoteId\" is not allowed to be empty"
    }
}

transactionId:

{
    "errorInformation": {
        "errorCode": "3102",
        "errorDescription": "Missing mandatory element - \"TransactionId\" is not allowed to be empty"
    }
}

Steps to Reproduce

  1. POST a /quotes request with an empty quoteId or transactionId value.
  2. A 202 accepted will be returned instead of a 400 with the appropriate error message above.

Specifications

  • Component (if known): quoting-service
  • Version: 8.8.0-snapshot
  • Platform: all
  • Subsystem:
  • Type of testing: manual
  • Bug found/raised by: TIPS

Pull Requests:

Notes:

  • Severity when opened: low
  • Priority when opened: low
@ndonnan ndonnan added the bug label Jan 16, 2020
@ndonnan ndonnan self-assigned this Jan 16, 2020
@elnyry-sam-k elnyry-sam-k added this to the Sprint 8.8 milestone Jan 17, 2020
@amarmodus amarmodus self-assigned this Jan 17, 2020
@amarmodus
Copy link

Check in PR(mojaloop/postman#80) for the test screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants