Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement autoPositionReset config to settlementModel #1211

Closed
11 of 14 tasks
ggrg opened this issue Feb 7, 2020 · 0 comments
Closed
11 of 14 tasks

Implement autoPositionReset config to settlementModel #1211

ggrg opened this issue Feb 7, 2020 · 0 comments
Assignees
Labels

Comments

@ggrg
Copy link
Member

ggrg commented Feb 7, 2020

Goal:

As a Hub Operator
I want to be able to define if position should be automatically reset on settlement model level
so that upon settling a settlement, positions are updated according to the settlement model configuration

Tasks:

  • Add settlementModel.autoPositionReset db column [@ggrg]
  • Fix POST /settlementModel to plural /settlementModels [@ggrg]
  • Update POST /settlementModels admin api to require and populate the newly added column [@ggrg]
  • Fix unit tests for central-ledger [@ggrg]
  • Update GET /settlementModels and GET /settlementModels/{name} to report autoPositionReset config (moved to Implement settlementModels management - GET and PUT operations #1207)
  • Enhance updateSettlementById handler to use the newly added config, so that when autoPositionReset is set to false, settlement transfer is not created [@ggrg]

Acceptance Criteria:

  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • Whether positions are to be automatically reset /adjusted upon Settling or not, can be set using config at deployment time by Hub Operators.

Pull Requests:

Follow-up:

  • Create stories to allow position reset for ledgers other than POSITION

Dependencies:

  • N/A

Accountability:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant