Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

realize p2p transaction using thirdparty-scheme-adapter - PISP side #2060

Closed
52 of 56 tasks
eoln opened this issue Feb 17, 2021 · 3 comments
Closed
52 of 56 tasks

realize p2p transaction using thirdparty-scheme-adapter - PISP side #2060

eoln opened this issue Feb 17, 2021 · 3 comments
Assignees
Labels
oss-pisp OSS PISP team's items - stories, bugs, epics story
Milestone

Comments

@eoln
Copy link

eoln commented Feb 17, 2021

Goal:

As a Developer
I want to apply the same patterns to all parts of the code (with thirdparty-scheme-adapter)
so that we can effectively work and build the codebase

Acceptance Criteria:

  • PISPTransactionModel refactored to newest API changes
  • integration test

Complexity: Medium> there is already POC code
Uncertainty: Low > there is already POC code


Tasks:

  • update dependencies
  • update docker images to use latest
  • http-request base class refactor
  • reexport Typescript interfaces for sdk-scheme-adapter API so thridparty-scheme-adapter can use them
  • publish sdk-scheme-adapter to npm so can be used as dep by thirdparty-scheme-adapter
  • fixing sdk-scheme-adapter npm installation problem
  • fixing export of Typescript in api-sinippets
  • reexport Typescript interfaces for sdk-standard-components from api-snippets types
  • prepare P2PTransaction detailed UML sequence
  • migrate DeferredJob from sdk-scheme-adapter
  • fix/update api-snippets autogenerated files & drop hello example endpoint
  • fix publish CI step dependency for thirdparty-scheme-adapter
  • fix UnresolvedPromiseWarning in outbound/authorizations.model.test
  • migrate Async2SyncModel from sdk-scheme-adapter
  • expose sync patchThirdpartyRequestsTransaction endpoint
  • integration tests for SDKOutgoingRequests.requestPartiesInformation
  • sdk/pisp/dfsp backend request classes
  • change in design: propagate interface changes of POST /thridpartyRequests/transactions payload -> api-snippets
  • PISPTransactionModel refactor - use api-snippets for partyLookup endpoint @ Outbound
  • PISPTransactionModel refactor - use new payload to call /thridpartyRequests/transactions
  • PISPTransactionModel refactor - use of deferredJob
  • PISPTransactionModel feat - calculate timeout for each deferred job from expiration field send in initiate step (will be covered in another story)
  • PISPTransactionModel feat - two step hazard mitigation
  • improve unit tests to reach the coverage
  • integration test

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

Follow-up:

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@eoln eoln added oss-pisp OSS PISP team's items - stories, bugs, epics story labels Feb 17, 2021
@eoln eoln changed the title refactor thirdparty-scheme-adapter to use sync endpoints from sdk-scheme-adapter realize p2p transaction using thirdparty-scheme-adapter Feb 17, 2021
@eoln eoln added the to-be-refined This story is ready to be groomed label Feb 17, 2021
@lewisdaly lewisdaly removed the to-be-refined This story is ready to be groomed label Feb 17, 2021
@eoln eoln self-assigned this Feb 18, 2021
@eoln eoln added this to the Sprint 13.2 milestone Feb 19, 2021
@lewisdaly lewisdaly modified the milestones: Sprint 13.2, Sprint 13.3 Mar 3, 2021
@eoln eoln changed the title realize p2p transaction using thirdparty-scheme-adapter realize p2p transaction using thirdparty-scheme-adapter - PISPSide Mar 9, 2021
@eoln eoln changed the title realize p2p transaction using thirdparty-scheme-adapter - PISPSide realize p2p transaction using thirdparty-scheme-adapter - PISP side Mar 9, 2021
@lewisdaly
Copy link
Contributor

I'm not sure where this belongs, but there is no handler for PATCH /thirdpartyRequests/{id} in the thirdparty-api-adapter. @eoln should this be a part of this ticket or (my preference) another?

@lewisdaly
Copy link
Contributor

I'm also realising that that call is in the API draft but not the latest sequences... my bad :(.

@eoln
Copy link
Author

eoln commented Mar 10, 2021

@lewisdaly PATCH is used by DFSPTransitionModel so I added this as task to (#2108)

@spoonernz spoonernz modified the milestones: Sprint 13.3, Sprint 13.4 Mar 17, 2021
@lewisdaly lewisdaly modified the milestones: Sprint 13.4, Sprint 13.5 Mar 31, 2021
@eoln eoln closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oss-pisp OSS PISP team's items - stories, bugs, epics story
Projects
None yet
Development

No branches or pull requests

3 participants