Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues exceeding 64 character limit in names #2375

Closed
tdaly61 opened this issue Aug 9, 2021 · 2 comments
Closed

issues exceeding 64 character limit in names #2375

tdaly61 opened this issue Aug 9, 2021 · 2 comments
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service infra-bug An infrastructure issue or bug such as in helm charts or documentation

Comments

@tdaly61
Copy link

tdaly61 commented Aug 9, 2021

Summary:
mojaloop component names are so long as to exceed helm/k8s naming limits when mojaloop chart is installed

Severity:
Medium

Priority:
Medium

Expected Behavior
Mojaloop component names should be kept far enough below the 64 character maximum so that users deploying from helm will not exceed the 64 character limit.

Error: Deployment.apps "mojaloop-centralsettlement-handler-deferredsettlement" is invalid: [spec.template.spec.volumes[1].name: Invalid value: "mojaloop-centralsettlement-handler-deferredsettlement-sidecar-vol": must be no more than 63 characters, spec.template.spec.containers[1].volumeMounts[0].name: Not found: "mojaloop-centralsettlement-handler-deferredsettlement-sidecar-vol"]

Steps to Reproduce

  • helm upgrade --install --namespace ml-app mojaloop mojaloop/mojaloop -f /vagrant/install/k3d-values-oss-lab-v2.yaml

or more simply

  • helm upgrade --install --namespace ml-app mojaloop mojaloop/mojaloop.

Specifications

  • Component (if known):mojaloop helm deploy
  • Version: 13.0.1
  • Platform: probably all platforms as it is helm/k8s limit , though I am specifically testing on Rancher k3s.
  • Subsystem:
  • Type of testing:
  • Bug found/raised by: Tom Daly

Notes:

  • Severity when opened:
  • Priority when opened:
@tdaly61 tdaly61 added the bug Something isn't working or it has wrong behavior on a Mojaloop Core service label Aug 9, 2021
@elnyry-sam-k elnyry-sam-k added the infra-bug An infrastructure issue or bug such as in helm charts or documentation label Aug 9, 2021
@tdaly61
Copy link
Author

tdaly61 commented Oct 25, 2021

hey @mdebarros , given your code changes to the v14 PoC have show how to fix this BUT have not yet been reviewed accepted (however that is done) ..what should we do with this issue ?

@elnyry-sam-k
Copy link
Member

Closing it as duplicate of #2322 - please reopen if these are not the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service infra-bug An infrastructure issue or bug such as in helm charts or documentation
Projects
None yet
Development

No branches or pull requests

2 participants