Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoting-Service is incorrectly handling failed responses to FSPs when forwarding requests #2435

Open
mdebarros opened this issue Aug 26, 2021 · 0 comments
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it to-be-refined This story is ready to be groomed

Comments

@mdebarros
Copy link
Member

mdebarros commented Aug 26, 2021

Summary:
Quoting-Service is incorrectly handling failed responses to FSPs when forwarding requests.

https://github.com/mojaloop/quoting-service/blob/master/src/lib/http.js#L63 <-- the Following line of code shows that the Quoting-Service will translate all errors to ErrorHandler.Enums.FSPIOPErrorCodes.DESTINATION_COMMUNICATION_ERROR when the HTTP status code does not match 404.

Severity:
High

Priority:
Medium

Expected Behavior

Quoting-Service should correctly map the error response to the appropriate FSPIOP error. For example:

  • ErrorHandler.Enums.FSPIOPErrorCodes.DESTINATION_COMMUNICATION_ERROR (i.e. 1xxx) is only applicable when the Quoting-Service is unable to communicate with the FSP service.
  • All other errors should be mapped to an applicable FSPIOP Client Error

etc...

Steps to Reproduce

  1. TBD

Specifications

  • Component (if known): Quoting-service
  • Version: 12.0.7
  • Platform:
  • Subsystem:
  • Type of testing: Manaul
  • Bug found/raised by: @mdebarros

Notes:

  • Severity when opened: High
  • Priority when opened: Medium
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it to-be-refined This story is ready to be groomed
Projects
None yet
Development

No branches or pull requests

1 participant