Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node JS version for the ttk toolkit ui #3459

Closed
7 tasks done
PaulGregoryBaker opened this issue Aug 7, 2023 · 3 comments
Closed
7 tasks done

Update Node JS version for the ttk toolkit ui #3459

PaulGregoryBaker opened this issue Aug 7, 2023 · 3 comments

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented Aug 7, 2023

Tasks:

  • Update all dependencies
  • Verify that ignored dependency upgrades are still applicable .ncurc.yaml
  • Verify that ignored audit issues are still applicable audit-ci.jsonc
  • Update project to the latest LTS Nodejs version run CI tests
  • Update CI workflow based on the latest fixes made to the SDK-Scheme-Adapter CI workflow for NVM, etc.
  • Resolve image scan issues and port whitelisting

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@oderayi
Copy link

oderayi commented Sep 26, 2023

Returning this to the PI backlog as there is no adequate test coverage in this repo. Verifying the upgrade will have to be done manually.

@kleyow
Copy link

kleyow commented Jan 4, 2024

react-scripts>eslint-config-react-app>eslint-plugin-jsx-a11y>axe-core

Package "axe-core@4.8.3" is licensed under "MPL-2.0" which is not permitted by the --onlyAllow flag. Exiting.
MPL 2.0 is copy-left license, means incompatible with Apache 2.0 Mojaloop licensing.

This should affect all react based services.

On the recommendation of @elnyry-sam-k I am disabling the audit license check "because its not part of the Mojaloop core platform - strictly speaking and is not our core offering.. Its only the tool we use for testing" and opening an issue to tackle the licensing issue.

@kleyow kleyow changed the title Update Node JS version for the ttk toolkit ui Update Node JS version for the ttk toolkit ui (Blocked by licensing) Jan 4, 2024
@kleyow kleyow changed the title Update Node JS version for the ttk toolkit ui (Blocked by licensing) Update Node JS version for the ttk toolkit ui Jan 4, 2024
@kleyow
Copy link

kleyow commented Jan 4, 2024

Follow up issue. #3710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants