feat(mojaloop/#3565): database and cache optimizations #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleyow
changed the title
kleyow
commented
Oct 13, 2023
| quoteRequest.amount.amount, quoteRequest.amount.currency, payerEnumVals), | ||
| this.db.createPayeeQuoteParty(txn, refs.quoteId, quoteRequest.payee, | ||
| quoteRequest.amount.amount, quoteRequest.amount.currency, payeeEnumVals) | ||
| ]) |
There was a problem hiding this comment.
Putting off consolidating these two into a single insert since createQuoteParty has itself several queries that would also need refactoring to a single insert for the quote pair.
kleyow
commented
Oct 13, 2023
| @@ -196,10 +199,11 @@ const config = new Config() | |||
| * @description Starts the web server | |||
| */ | |||
| async function start () { | |||
| const cache = new Cache() | |||
There was a problem hiding this comment.
I can pass a singular cache to the db and for api request caching but have kept them seperate for now. Any thoughts on a singular cache for everything?
kleyow
requested review from
mdebarros,
elnyry-sam-k,
oderayi,
vijayg10 and
bushjames
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#3565): database and cache optimizations - mojaloop/project#3564 mojaloop/project#3565
getParticipantByName/EnabledgetParticipantandgetParticipantEndpointsdatabase cachingfetchParticipantsapi functiongetParticipantcalls in validating quote requestshandleQuoteRequest