-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor config to handle diff inbound/outbound certs #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me.
Just some minor comments for consideration.
These typically publish responses into redis for state machines to continue a flow. | ||
|
||
Inbound models handle the processing of Switch requests but they themselves | ||
can make requests to the accomplish a certain flow the initial inbound request initiates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason to manually word wrap this? <-- comment applies through-out the readme changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easier to read when not rendered and I believe Vim users hate long lines since they are a pain to navigate.
} | ||
}, | ||
CONTROL: { | ||
MGMT_API_WS_URL: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need any TLS config for MGM API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I know of based off of looking at mojaloop-connector
Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>
No description provided.