Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor config to handle diff inbound/outbound certs #146

Merged
merged 10 commits into from
May 31, 2022

Conversation

kleyow
Copy link
Collaborator

@kleyow kleyow commented May 27, 2022

No description provided.

@kleyow kleyow marked this pull request as ready for review May 31, 2022 01:11
README.md Outdated Show resolved Hide resolved
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

Just some minor comments for consideration.

These typically publish responses into redis for state machines to continue a flow.

Inbound models handle the processing of Switch requests but they themselves
can make requests to the accomplish a certain flow the initial inbound request initiates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to manually word wrap this? <-- comment applies through-out the readme changes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier to read when not rendered and I believe Vim users hate long lines since they are a pain to navigate.

}
},
CONTROL: {
MGMT_API_WS_URL: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any TLS config for MGM API?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I know of based off of looking at mojaloop-connector

kleyow and others added 3 commits May 31, 2022 10:41
@kleyow kleyow merged commit 4649743 into mojaloop:master May 31, 2022
@kleyow kleyow deleted the feat/control branch May 31, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants