Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thank you #64

Open
Andrei-Pozolotin opened this issue Nov 29, 2017 · 8 comments
Open

thank you #64

Andrei-Pozolotin opened this issue Nov 29, 2017 · 8 comments

Comments

@Andrei-Pozolotin
Copy link

thank you for the plugin idea; just FYI:

proof-of-concept simplified plugin incarnation:
https://github.com/random-maven/flatten-maven-plugin

which resolves:
#63
#59
#58
#57
etc.

@tribbloid
Copy link

Thanks a lot Andrei, can you merge #61 as well? The maintainer of this project went silent for a long time.

@tribbloid
Copy link

@Andrei-Pozolotin Glorious! I'm merging my ticket into yours.
Thanks a lot sir!

@mattnelson
Copy link

I am interested in a few of these changes, but I don't think this plugin should be considered dead and forked.

@Andrei-Pozolotin can you with @khmarbaise and the other maintainers of this plugin to integrate these changes and avoid the fragmentation?

@tribbloid
Copy link

@mattnelson: I agree, this plugin (mojohaus version) supports clean mojo which is not supported by @Andrei-Pozolotin 's version. It's a waste of everyone's time to integrate features into all forks.

@khmarbaise
Copy link
Member

I appreciated your pull request...

@Andrei-Pozolotin
Copy link
Author

@ALL :

I think there is a basic design issue with mojohaus version: mutable vs immutable model

which can be addressed by something like this:

random-maven/flatten-maven-plugin

// after clone():
// do not interpolate anything any more 
// only remove content or add static content
final Model model = project.getModel().clone(); 

but that change does not look like as a simple PR to the mojohaus, but rather complete plugin redesign, which I did in random-maven version

@hohwille
Copy link
Member

thank you for the plugin idea

you are welcome :)

but that change does not look like as a simple PR to the mojohaus, but rather complete plugin redesign, which I did in random-maven version

So what is the plan then?
According to what you are saying you are not interested in improving this plugin but want to go with your own fork?
Did you see that we are getting other PRs that we merged. This will IMHO lead to two different directions and duplicated effort.
Sorry if reactions are slow here (I am involved in ~10 other OSS projects in my rare spare time). Feel free to join mojohaus and support this plugin better directly.
As @khmarbaise said we would welcome PRs from you to improve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants