Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example app is currently broken -- Readme contains no instructions for compilation or tests #67

Closed
4 tasks
silasjmatson opened this issue Jul 19, 2017 · 5 comments

Comments

@silasjmatson
Copy link
Contributor

silasjmatson commented Jul 19, 2017

Since we switched to using webpack for asset compilation, the example app no longer works.

I think we should have a script for both brunch compilation and webpack compilation in the package.json.

Tasks:

  • Update & Fix Example App (w/2 ways to compile -- brunch & webpack)

Questions:

  • Should the example app reference the compiled assets in the root priv/static/ directory? I think it should reference them identically to how an app in the wild would do so. Not sure what this would entail.
  • Should the example app reference phoenix_html and phoenix from the root directory in the package.json? (It currently does: See here)
  • Add development/contribution guides
  • Add bin/ci script that builds and tests the project (using the example app)
  • Update CI server to fix issues (it's still passing even though it has issues, and it uses the bin/setup script, which is outdated)

From https://semaphoreci.com/ir/torch/branches/bug-64-javascript-error/builds/1

# lines removed
06:38:26.283 [error] GenServer #PID<0.4513.0> terminating
** (KeyError) key :password not found in: [types: Postgrex.DefaultTypes, username: "runner", backoff_type: :stop, pool: DBConnection.Connection, database: "template1", otp_app: :example, repo: Example.Repo, adapter: Ecto.Adapters.Postgres, hostname: "localhost", pool_size: 10]
    (elixir) lib/keyword.ex:333: Keyword.fetch!/2
    (postgrex) lib/postgrex/protocol.ex:581: Postgrex.Protocol.auth_md5/4
    (postgrex) lib/postgrex/protocol.ex:475: Postgrex.Protocol.handshake/2
    (db_connection) lib/db_connection/connection.ex:134: DBConnection.Connection.connect/2
    (connection) lib/connection.ex:622: Connection.enter_connect/5
    (stdlib) proc_lib.erl:240: :proc_lib.init_p_do_apply/3
Last message: nil
State: Postgrex.Protocol
** (Mix) The database for Example.Repo couldn't be created: an exception was raised:
    ** (KeyError) key :password not found in: [types: Postgrex.DefaultTypes, username: "runner", backoff_type: :stop, pool: DBConnection.Connection, database: "template1", otp_app: :example, repo: Example.Repo, adapter: Ecto.Adapters.Postgres, hostname: "localhost", pool_size: 10]
        (elixir) lib/keyword.ex:333: Keyword.fetch!/2
        (postgrex) lib/postgrex/protocol.ex:581: Postgrex.Protocol.auth_md5/4
        (postgrex) lib/postgrex/protocol.ex:475: Postgrex.Protocol.handshake/2
        (db_connection) lib/db_connection/connection.ex:134: DBConnection.Connection.connect/2
        (connection) lib/connection.ex:622: Connection.enter_connect/5
        (stdlib) proc_lib.erl:240: :proc_lib.init_p_do_apply/3
npm ERR! addLocal Could not install /home/runner/deps/phoenix
npm ERR! addLocal Could not install /home/runner/deps/phoenix_html
-npm ERR! Linux 3.13.0-61-generic
npm ERR! argv "/home/runner/.nvm/versions/node/v4.6.2/bin/node" "/home/runner/.nvm/versions/node/v4.6.2/bin/npm" "install"
npm ERR! node v4.6.2
npm ERR! npm  v2.15.11
npm ERR! path /home/runner/deps/phoenix
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall open

npm ERR! enoent ENOENT: no such file or directory, open '/home/runner/deps/phoenix'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! Please include the following file with any support request:
npm ERR!     /home/runner/torch/example/npm-debug.log

# lines removed

warning: the dependency :postgrex requires Elixir "~> 1.3.4 or ~> 1.4" but you are running on v1.3.0

# lines removed
@mbenatti
Copy link

Hi, I'm evaluating this framework but I got problems.
I think this is a part of the issue: I followed the guide in readme.md using umbrella app for phoenix 1.3 but its broken,following all instalation guide I got compilation error, also dependency don't work and not generate the mix commands for torch.

@zberkom
Copy link
Contributor

zberkom commented Aug 10, 2017

@mbenatti The project currently supports phoenix 1.2 projects and we're working on adding full phoenix 1.3 support, which includes fixing the issues outlined in this issue along with other improvements. Unfortunately, I don't have an ETA on when we'll get to it, but we'll do our best to take care of these issues as soon as possible.

@mbenatti
Copy link

@zberkom Thank you for the feedback.
Congratulations for the Good work did in Torch, I think this is a framework with a huge potential...

@zberkom
Copy link
Contributor

zberkom commented Aug 10, 2017

@mbenatti I agree - we already use it in many of our web projects here at Infinite Red, but it's definitely a bit rough around the edges still.

@zberkom
Copy link
Contributor

zberkom commented Apr 13, 2018

Closing after releasing v2.0.0-rc.1

@zberkom zberkom closed this as completed Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants