You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since we switched to using webpack for asset compilation, the example app no longer works.
I think we should have a script for both brunch compilation and webpack compilation in the package.json.
Tasks:
Update & Fix Example App (w/2 ways to compile -- brunch & webpack)
Questions:
Should the example app reference the compiled assets in the root priv/static/ directory? I think it should reference them identically to how an app in the wild would do so. Not sure what this would entail.
Should the example app reference phoenix_html and phoenix from the root directory in the package.json? (It currently does: See here)
Add development/contribution guides
Add bin/ci script that builds and tests the project (using the example app)
Update CI server to fix issues (it's still passing even though it has issues, and it uses the bin/setup script, which is outdated)
Hi, I'm evaluating this framework but I got problems.
I think this is a part of the issue: I followed the guide in readme.md using umbrella app for phoenix 1.3 but its broken,following all instalation guide I got compilation error, also dependency don't work and not generate the mix commands for torch.
@mbenatti The project currently supports phoenix 1.2 projects and we're working on adding full phoenix 1.3 support, which includes fixing the issues outlined in this issue along with other improvements. Unfortunately, I don't have an ETA on when we'll get to it, but we'll do our best to take care of these issues as soon as possible.
Since we switched to using webpack for asset compilation, the example app no longer works.
I think we should have a script for both brunch compilation and webpack compilation in the package.json.
Tasks:
Questions:
priv/static/
directory? I think it should reference them identically to how an app in the wild would do so. Not sure what this would entail.phoenix_html
andphoenix
from the root directory in thepackage.json
? (It currently does: See here)bin/ci
script that builds and tests the project (using the example app)bin/setup
script, which is outdated)From https://semaphoreci.com/ir/torch/branches/bug-64-javascript-error/builds/1
The text was updated successfully, but these errors were encountered: