Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slim templates #84

Closed
danielberkompas opened this issue Apr 20, 2018 · 4 comments
Closed

Add Slim templates #84

danielberkompas opened this issue Apr 20, 2018 · 4 comments

Comments

@danielberkompas
Copy link
Contributor

Currently, we only have templates for EEx.

@yordis
Copy link

yordis commented Jun 4, 2018

@danielberkompas I would leave the project embracing EEx only mate. I wouldn't split the community between EEx and Slim as it happened in the Rails ecosystem.

Realistically from the experience of Ruby ecosystem, it just add friction and without techinical reasons to back it up outside of personal preferences.

But, that is just my opinion.

@chevinbrown
Copy link

For me, adding templating other than the defaults chosen by phoenix only hurt the core application.
I ❤️ slim, but for other members on my team I could see this causing adoption friction. Just an outsider's 2 cents. 😸

@jivko-chobanov
Copy link

Please mention that in the docs front page. Maybe around: "NOTE: If you choose to use slim templates, you will need to install Phoenix Slim.".

I lost several hours trying to debug torch, expecting it to have slim support as it proclaims in the docs.

@cpjolicoeur
Copy link
Member

This is now noted in the README. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants