You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First time to check the size of the workspace in a streaming way, the second time to actually save it (the name rExecutorService.saveWorkspace is a bit confusing, this method does not save yet, but calls a callback that can do something with the inputstream, so it could also check the size instead of saving it)
This is a bit annoying because it potentially will slow things. Check how much this affects usability.
The text was updated successfully, but these errors were encountered:
How to Reproduce
When saving workspace it's turned into an
ArmadilloWorkspace
class, loading the workspace as a bytearray to determine its size:molgenis-service-armadillo/armadillo/src/main/java/org/molgenis/armadillo/storage/ArmadilloWorkspace.java
Line 13 in 4c12f87
Proposed solution
See if we can run this twice:
molgenis-service-armadillo/armadillo/src/main/java/org/molgenis/armadillo/command/impl/CommandsImpl.java
Line 202 in 4c12f87
First time to check the size of the workspace in a streaming way, the second time to actually save it (the name
rExecutorService.saveWorkspace
is a bit confusing, this method does not save yet, but calls a callback that can do something with the inputstream, so it could also check the size instead of saving it)This is a bit annoying because it potentially will slow things. Check how much this affects usability.
The text was updated successfully, but these errors were encountered: