Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When saving a Workspace, complete workspace is kept in memory to check its size #778

Open
marikaris opened this issue Sep 10, 2024 · 0 comments
Labels
bug 🐛 Something isn't working

Comments

@marikaris
Copy link
Collaborator

How to Reproduce

When saving workspace it's turned into an ArmadilloWorkspace class, loading the workspace as a bytearray to determine its size:

Proposed solution

See if we can run this twice:


First time to check the size of the workspace in a streaming way, the second time to actually save it (the name rExecutorService.saveWorkspace is a bit confusing, this method does not save yet, but calls a callback that can do something with the inputstream, so it could also check the size instead of saving it)
This is a bit annoying because it potentially will slow things. Check how much this affects usability.

@marikaris marikaris added bug 🐛 Something isn't working triage labels Sep 10, 2024
@marikaris marikaris removed the triage label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant