Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize, stabilize file downloads #44

Closed
nbitzz opened this issue Nov 1, 2023 · 9 comments · May be fixed by #16
Closed

Optimize, stabilize file downloads #44

nbitzz opened this issue Nov 1, 2023 · 9 comments · May be fixed by #16
Assignees

Comments

@nbitzz
Copy link
Contributor

nbitzz commented Nov 1, 2023

Maybe stream attachments & fetch messages from the API as the download goes on to allow it to start immediately?

@nbitzz
Copy link
Contributor Author

nbitzz commented Nov 16, 2023

fetch messages from the API as the download goes on

Guess we should probably use the Workers API for this..? @Jack5079
Another alternative is just getting another message after we've sent the data from the last message, I don't think that the overhead from that would be significant + would probably be better anyway since we aren't wasting API requests if the request gets aborted + it's a lot easier to implement

@nbitzz nbitzz self-assigned this Nov 16, 2023
@nbitzz
Copy link
Contributor Author

nbitzz commented Mar 4, 2024

readFileStream still needs a little cleanup but this issue is basically done so

@nbitzz
Copy link
Contributor Author

nbitzz commented Mar 5, 2024

@Jack5079 Are you like.going to handle fixing readFileStream or do i do it.Cause if you are i'll actually i'll just assign you now hold on

@Jack5079
Copy link
Member

Jack5079 commented Mar 5, 2024

@Jack5079 Are you like.going to handle fixing readFileStream or do i do it.Cause if you are i'll actually i'll just assign you now hold on

image

@nbitzz
Copy link
Contributor Author

nbitzz commented Mar 5, 2024

Meow

@Jack5079 Jack5079 assigned ghost Mar 5, 2024
@Jack5079
Copy link
Member

Jack5079 commented Mar 5, 2024

image

@nbitzz
Copy link
Contributor Author

nbitzz commented Mar 5, 2024

We should blow her up

@ghost
Copy link

ghost commented Mar 5, 2024

you're going to do WHAAAAAA

@nbitzz
Copy link
Contributor Author

nbitzz commented Mar 7, 2024

Oh wait this is basically done . Basically just cleanup so i will close

@nbitzz nbitzz closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants