Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"source" field in normalized JSON? #2

Open
darrenmartyn opened this issue Jul 8, 2020 · 5 comments
Open

"source" field in normalized JSON? #2

darrenmartyn opened this issue Jul 8, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@darrenmartyn
Copy link

Would it be feasible to add a "source" field to the JSON/indexed data, so you could "tag" entries as being from certain leaks.

This could be very useful when trying to go back later and attribute where a piece of data came from - but unsure if it would have performance impacts?

@moloch-- moloch-- added the enhancement New feature or request label Jul 8, 2020
@moloch--
Copy link
Owner

moloch-- commented Jul 8, 2020

I don't think it would have much of an impact on performance, most of the code operates on lines not the actual content of the line, so there's little code that would need to change too. A few other folks have been asking for something like this so I'll probably look at adding it. It would affect the bloom filter's ability to effectively de-duplicate identical user/password combos since they'd be from different sources, so there'd could be a modest impact to index/sort times but i don't think there'd be a large impact to search times.

@aaronkaplan
Copy link

Any news on this feature request?

@moloch--
Copy link
Owner

Not had time to work on it yet sorry!

@aaronkaplan
Copy link

aaronkaplan commented Feb 16, 2021 via email

@moloch--
Copy link
Owner

Maybe, most of the code only cares about "lines" in a file, you'd have to extend the normalizer to add a "source" field to the JSON format, and extend the few parts of the code that parse the JSON to optionally deal with the extra field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants