Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTime is not invalid like it should be when using hour 15 with 12-hour time token. #1549

Open
Matthematic opened this issue Dec 3, 2023 · 2 comments · May be fixed by #1562
Open

DateTime is not invalid like it should be when using hour 15 with 12-hour time token. #1549

Matthematic opened this issue Dec 3, 2023 · 2 comments · May be fixed by #1562
Labels
issue: bug

Comments

@Matthematic
Copy link

Describe the bug
Correct me if I'm wrong, but shouldn't this return an invalid DateTime?

luxon.DateTime.fromFormat('11-08-2023 15:00 AM', 'MM-dd-yyyy hh:mm a').toString()
// '2023-11-08T15:00:00.000-06:00'

To Reproduce
Just go to the Luxon docs and paste the example above into the console.
image

Actual vs Expected behavior
The date string supplied is using hour 15 with a meridian, and the format string is expecting 12-hour time. Shouldn't luxon notice that hour 15 is out of bounds and return an Invalid object?

Desktop (please complete the following information):

  • OS: MacOS Ventura 13.1
  • Browser: Chrome 118.0.5993.117
  • Luxon version: 3.4.4
  • Your timezone: America/Chicago
@icambron
Copy link
Member

icambron commented Dec 3, 2023

Probably should, yeah.

Matthematic pushed a commit to Matthematic/luxon that referenced this issue Jan 6, 2024
Return Invalid DateTime for using meridiem with 24-hour (moment#1549)
429c38e
@Matthematic Matthematic linked a pull request Jan 6, 2024 that will close this issue
Open
Matthematic added a commit to Matthematic/luxon that referenced this issue Jan 6, 2024
@Matthematic
Return Invalid DateTime for using meridiem with 24-hour (moment#1549)
7152ca4
@KengSSK
Copy link

KengSSK commented Jan 11, 2024

Recommended for beginners.

@KengSSK KengSSK mentioned this issue Jan 11, 2024
Closed
@KengSSK KengSSK mentioned this issue Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return Invalid DateTime for using meridiem with 24-hour (#1549) Matthematic/luxon
3 participants
@icambron @Matthematic @KengSSK